Skip to content

Fix WidgetText::Text ignoring fallback font and overrides #7361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Aug 13, 2025
Merged

Fix WidgetText::Text ignoring fallback font and overrides #7361

merged 6 commits into from
Aug 13, 2025

Conversation

lucasmerlin
Copy link
Collaborator

@lucasmerlin lucasmerlin mentioned this pull request Jul 14, 2025
Closed
@lucasmerlin lucasmerlin added bug Something is broken egui labels Jul 14, 2025
@lucasmerlin lucasmerlin added this to the 0.32.1 milestone Jul 14, 2025
@github-actions GitHub Actions
Copy link

Preview available at https://egui-pr-preview.github.io/pr/7361-lucasfix-rich-text-font-fallback
Note that it might take a couple seconds for the update to show up after the preview_build workflow has completed.

@lucasmerlin lucasmerlin changed the title Fix WidgetText::Text ignoring fallback font Fix WidgetText::Text ignoring fallback font and overrides Jul 22, 2025
@lucasmerlin lucasmerlin mentioned this pull request Jul 22, 2025
Merged
emilk
emilk approved these changes Aug 5, 2025
View reviewed changes
Copy link
Owner

@emilk emilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@lucasmerlin
Allow customizing fallback font in AtomLayout (#7382)
d61d36d 
- merge after #7361 (this pr requires
the clone derive introduced there)

Before it was hard coded to TextStyle::Button, but it should be
customizable.
@lucasmerlin
Rename
8cdea5b
@lucasmerlin
Fmt
e3b738f
@SUPERCILEX
Copy link

Any chance releasing this can be prioritized? I'm eagerly awaiting the fix

@emilk emilk merged commit c2de29a into main Aug 13, 2025
47 checks passed
@emilk emilk deleted the lucas/fix-rich-text-font-fallback branch August 13, 2025 12:56
emilk pushed a commit that referenced this pull request Aug 15, 2025
@lucasmerlin @emilk
Fix WidgetText::Text ignoring fallback font and overrides (#7361)
97fe124 
* closes #7356
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilk emilk emilk approved these changes

Assignees
No one assigned
Labels
bug Something is broken egui
Projects
None yet
Milestone
0.32.1
Development

Successfully merging this pull request may close these issues.

Hint text font not working in 0.32
3 participants
@lucasmerlin @SUPERCILEX @emilk