Skip to content

feat: add start/1 API #241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: add start/1 API #241

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 19 additions & 6 deletions src/emqtt.erl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,8 @@
-include("logger.hrl").
-include("emqtt_internal.hrl").

-export([ start_link/0
-export([ start/1
, start_link/0
, start_link/1
]).

Expand Down Expand Up @@ -174,6 +175,7 @@
| {with_qoe_metrics, boolean()}
| {properties, properties()}
| {nst, binary()}
| {link, boolean()}
| {custom_auth_callbacks, custom_auth_callbacks()}).

-type(topic() :: binary()).
Expand Down Expand Up @@ -354,12 +356,18 @@
%%--------------------------------------------------------------------

-spec(start_link() -> gen_statem:start_ret()).
start_link() -> start_link([]).
start_link() -> start([{link, true}]).

-spec(start_link(map() | [option()]) -> gen_statem:start_ret()).
start_link(Options) when is_map(Options) ->
start_link(maps:to_list(Options));
start(Options#{link => true});
start_link(Options) when is_list(Options) ->
start([{link, true} | Options]).

-spec(start(map() | [option()]) -> gen_statem:start_ret()).
start(Options) when is_map(Options) ->
start(maps:to_list(Options));
start(Options) when is_list(Options) ->
ok = emqtt_props:validate(
proplists:get_value(properties, Options, #{})),
StatmOpts = case proplists:get_bool(low_mem, Options) of
Expand All @@ -371,12 +379,17 @@ start_link(Options) when is_list(Options) ->
{hibernate_after, 50}
]
end,

Fname = case proplists:get_bool(link, Options) of
true ->
start_link;
false ->
start
end,
case proplists:get_value(name, Options) of
undefined ->
gen_statem:start_link(?MODULE, [with_owner(Options)], StatmOpts);
gen_statem:Fname(?MODULE, [with_owner(Options)], StatmOpts);
Name when is_atom(Name) ->
gen_statem:start_link({local, Name}, ?MODULE, [with_owner(Options)], StatmOpts)
gen_statem:Fname({local, Name}, ?MODULE, [with_owner(Options)], StatmOpts)
end.

with_owner(Options) ->
Expand Down
13 changes: 12 additions & 1 deletion test/emqtt_SUITE.erl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,8 @@ all() ->

groups() ->
[{general, [],
[t_connect,
[t_start_no_link,
t_connect,
t_connect_timeout,
t_subscribe,
t_subscribe_qoe,
Expand Down Expand Up @@ -185,6 +186,16 @@ clean_retained(Topic) ->
t_props(_) ->
ok = emqtt_props:validate(#{'Payload-Format-Indicator' => 0}).

t_start_no_link(Config) ->
ConnFun = ?config(conn_fun, Config),
Port = ?config(port, Config),
{ok, C} = emqtt:start([{port, Port}]),
{ok, _} = emqtt:ConnFun(C),
{links, Links} = process_info(self(), links),
?assertNot(lists:member(C, Links)),
emqtt:stop(C),
ok.

t_connect(Config) ->
ConnFun = ?config(conn_fun, Config),
Port = ?config(port, Config),
Expand Down
Loading