Add test for sequential consistency in printing from a pthread. #25213
Conversation
| @@ -0,0 +1,3 @@ | |||
| if (!ENVIRONMENT_IS_PTHREAD) { | |||
| Module.print = (text) => { console.log(text); } | |||
| } | |||
There was a problem hiding this comment.
Why is this file needed? Shouldn't we be testing the default behaviour of emscripten_out
There was a problem hiding this comment.
Oh I see your are testing both.
What happens if you override Module.print on the pthreads too? i.e. is the if condition import here? I would hope not, since calls out should be proxied back to the main threads's print handler regardless.
There was a problem hiding this comment.
is the
ifcondition import here?
Yes, it is important.
I would hope not, since calls
outshould be proxied back to the main threads's
No, that is not correct. If pthread overrides a print handler, then it is not proxied to the main thread.
emscripten/src/runtime_pthread.js
Line 88 in 80ca182
|
I'll close this since we were not able to remove the broken behavior. |
#19683 (comment)