Skip to content

Move the removal of flaky tests from previous run to also take place in singlethreaded runs. #25269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 15, 2025
Merged

Move the removal of flaky tests from previous run to also take place in singlethreaded runs. #25269

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b643ba5
Move the removal of flaky tests from previous run to also take place …
juj Sep 11, 2025
14f5830
Merge remote-tracking branch 'origin/main' into move_remove_flaky
juj Sep 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions test/parallel_testsuite.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,9 +111,6 @@ def run(self, result):
# issues.
# multiprocessing.set_start_method('spawn')

# Remove any old stale list of flaky tests before starting the run
utils.delete_file(common.flaky_tests_log_filename)

tests = self.get_sorted_tests()
contains_browser_test = any(test.is_browser_test() for test in tests)
use_cores = cap_max_workers_in_pool(min(self.max_cores, len(tests), num_cores()), contains_browser_test)
Expand Down
3 changes: 3 additions & 0 deletions test/runner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -562,6 +562,9 @@ def set_env(name, option_value):

check_js_engines()

# Remove any old test files before starting the run
utils.delete_file(common.flaky_tests_log_filename)

def prepend_default(arg):
if arg.startswith('test_'):
return default_core_test_mode + '.' + arg
Expand Down