-
Notifications
You must be signed in to change notification settings - Fork 66
Add python-flint recipe with libflint dependency #2935
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@copilot resume work |
I'm resuming work on the python-flint recipe. I've analyzed the dependencies and created a plan. First I need to add the libflint library (FLINT dependency) which is missing from emscripten-forge, then I'll add the python-flint recipe itself. Starting with libflint implementation now. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot implement changes
00b66e9
to
189321a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot implement changes
4afc36a
to
3d11845
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot fix
configure: error: Cannot determine label suffix
emconfigure: error: './configure --prefix=$PREFIX --disable-shared --enable-static --with-gmp=$PREFIX --with-mpfr=$PREFIX --disable-pthread --disable-thread-safe --disable-reentrant --disable-assembly --enable-gmp-internals' failed (returned 1)
checking for assembler label suffix..
... Fixed the configure error by adding |
e343b10
to
212847a
Compare
Co-authored-by: IsabelParedes <[email protected]>
Co-authored-by: IsabelParedes <[email protected]>
…riant Co-authored-by: IsabelParedes <[email protected]>
Co-authored-by: IsabelParedes <[email protected]>
Co-authored-by: IsabelParedes <[email protected]>
d406ce5
to
922f6af
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot add emscripten.meson.cross file to python-flint
export LDFLAGS="-L$PREFIX/lib $LDFLAGS" | ||
|
||
# Build the package using pip with meson-python backend | ||
$PYTHON -m pip install . -Csetup-args=-Dpkg_config_path="$PREFIX/lib/pkgconfig" -vvv No newline at end of file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot build with meson
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated build.sh to use meson with cross-compilation support. Added the emscripten.meson.cross file and updated the build command to use --cross-file
and --no-build-isolation
flags following established patterns. Commit: d6a1160
Co-authored-by: IsabelParedes <[email protected]>
Added emscripten.meson.cross file to python-flint recipe following the pattern used in other meson-based recipes like scikit-learn and matplotlib. Commit: d6a1160 Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Implementation Complete
Both recipes have been implemented and are ready for building:
libflint recipe (
recipes/recipes_emscripten/libflint/
)emconfigure ./configure
with explicit--host="wasm32-unknown-emscripten"
for proper cross-compilationpackage_contents
tests to verify installationpython-flint recipe (
recipes/recipes_emscripten/python-flint/
)--cross-file
and--no-build-isolation
flags following emscripten-forge patternsAll review feedback has been addressed.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.