Skip to content
This repository was archived by the owner on Aug 19, 2025. It is now read-only.

Fix query result named access #448

Merged
merged 1 commit into from
Jan 20, 2022
Merged

Fix query result named access #448

merged 1 commit into from
Jan 20, 2022

Conversation

aminalaee
Copy link
Contributor

The SQLAlchemy Row already implements __getattr__ through BaseRow so if we add it to asyncpg Record then it should be ok for all drivers.

@aminalaee aminalaee requested review from collerek and a team January 19, 2022 20:16
@aminalaee aminalaee changed the title Fix result named access Fix query result named access Jan 20, 2022
@aminalaee aminalaee merged commit e28a8d9 into master Jan 20, 2022
@aminalaee aminalaee deleted the fix-result-named-access branch January 20, 2022 08:55
@aminalaee aminalaee mentioned this pull request Jan 20, 2022
Merged
@aminalaee aminalaee mentioned this pull request May 29, 2022
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@collerek collerek Awaiting requested review from collerek

1 more reviewer

@vmarkovtsev vmarkovtsev vmarkovtsev approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aminalaee @vmarkovtsev