Skip to content
This repository was archived by the owner on Aug 19, 2025. It is now read-only.

Wrap types in typing.Optional where applicable #510

Merged
merged 3 commits into from
Dec 17, 2022
Merged

Wrap types in typing.Optional where applicable #510

merged 3 commits into from
Dec 17, 2022

Conversation

tsunyoku
Copy link
Contributor

No description provided.

@Kludex
Copy link
Contributor

Kludex commented Oct 20, 2022 •
edited
Loading

Hi @tsunyoku ! 👋
Would you mind enabling the flag https://mypy.readthedocs.io/en/stable/command_line.html#cmdoption-mypy-no-implicit-optional on our setup.cfg? That way, we can enforce those changes.

@tsunyoku
Copy link
Contributor Author

Hi @tsunyoku ! 👋 Would you mind enabling the flag https://mypy.readthedocs.io/en/stable/command_line.html#cmdoption-mypy-no-implicit-optional on our setup.cfg? That way, we can enforce those changes.

should be done!

Kludex
Kludex approved these changes Oct 20, 2022
View reviewed changes
Copy link
Contributor

@Kludex Kludex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🙏

@Kludex Kludex merged commit 7aa1326 into encode:master Dec 17, 2022
@tsunyoku tsunyoku deleted the fix-typing branch December 17, 2022 19:07
gaetano-guerriero pushed a commit to athenianco/morcilla that referenced this pull request Feb 27, 2023
@tsunyoku @Kludex @gaetano-guerriero
Wrap types in typing.Optional where applicable (encode#510)
79ac95e 
Co-authored-by: tsunyoku <[email protected]>
Co-authored-by: Marcelo Trylesinski <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
1 more reviewer

@Kludex Kludex Kludex approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tsunyoku @Kludex