compressor: expose compressor_library for per-route overrides #41177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to |
agrawroh
force-pushed
the
feat-compressor
branch
2 times, most recently
from
d6b7121 to
946d93b
Compare
Signed-off-by: Rohit Agrawal <[email protected]>
agrawroh
force-pushed
the
feat-compressor
branch
from
946d93b to
c7a96e6
Compare
wbpcode
reviewed
Sep 23, 2025
Comment on lines
727
to
737
| Envoy::Compression::Compressor::CompressorFactory& CompressorFilter::getCompressorFactory() const { | ||
| const auto* per_route_config = | ||
| Http::Utility::resolveMostSpecificPerFilterConfig<CompressorPerRouteFilterConfig>( | ||
| decoder_callbacks_); | ||
| if (per_route_config && per_route_config->compressorFactory()) { | ||
| return const_cast<Envoy::Compression::Compressor::CompressorFactory&>( | ||
| *per_route_config->compressorFactory()); | ||
| } | ||
| return const_cast<Envoy::Compression::Compressor::CompressorFactory&>( | ||
| config_->compressorFactory()); | ||
| } |
There was a problem hiding this comment.
Please create a field in the filter to store the route level config and ensure the field could be initialized only once. Note, the route config maybe changed because the route refreshment. Keeping the route level config in filter could avoid the potential inconsistence.
Signed-off-by: Rohit Agrawal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We have a requirement to select GZip vs. Brotli on some specific routes. In this PR, we are adding support for per-route compressor library override in the compressor filter. With this change, routes would be able to specify a different compressor library (e.g., gzip, brotli) via the
compressor_libraryfield on a per-route basis.This would allow different routes to use different compression algorithms and settings while maintaining the same filter configuration.
Commit Message: compressor: expose compressor_library for per-route overrides
Additional Description: Added support to allow different routes to use different compression algorithms and settings while maintaining the same filter configuration.
Risk Level: Low
Testing: Added Unit + Integration Tests
Docs Changes: Added
Release Notes: Added