type import flagged is missing and unpublished

[NullVoxPopuli]

idk if there is an existing rule to handle this case, but in Typescript, you can do:

import type { SomeType } from 'some-library';

for context, when transpiling to either CJS or MJS, the import doesn't make it to the output -- obviously a lint plugin can't know that is going to happen, but if there could be some way to relax n/no-missing-import and n/no-unpublished-import, (or require that some-library be in devDependencies if not found in the normal locations, this'd be a huge help <3

[aladdin-add]

I'm open to that - just wondering what's the best solution on it. the generated .d.ts still requires some-library, so will it break the the lib's users running tsc(if using ts)?

[Systemcluster]

I'd argue import type should either be ignored for this rule, or it would have to use a different resolver strategy. The second option seems more complicated, since type exports can be either from regular scripts, or .d.ts files in packages that are only referenced by the types field in package.json.

I'm getting this error multiple times here:

Note that @octokit/types only exports types. (The first error is a separate issue reported in #75)

[scagood]

We do have an option for ignoring type imports in no-unpublished-import ignoreTypeImport

Does this cover your use case?

[BrummbaerFr]

I am running into the exact same problem, using a private package that only exports types.

ignoreTypeImport does fix the problem for no-unpublished-import, however I had to just disable for no-missing-import for the problematic line.

[scagood]

mmm, could you possibly reproduce the issue in a small repo or in the eslint playground?

[BrummbaerFr]

mmm, could you possibly reproduce the issue in a small repo or in the eslint playground?

Sure! Here it is: eslint-n-missing-import-repro

Since the problematic package in my case is private, I used @octokit/types as pointed out by @Systemcluster.

[scagood]

That's perfect, thank you so much! 💚

I will try to look in the latter half of this week

[scagood]

I am thinking about trying to change from import-meta-resolve to enhanced-resolve 🤔

There are a few reasons for this:

1. You can just use require() to import it, unlike currently where we use a built version of import-meta-resolve
2. It provides a mechanism to implement the ts paths aliases ( no-missing-import does not work with "paths" from "tsconfig.json" #84)
3. This allows us to pass extensionAlias into the resolver ([file-extension-in-import] Does not work properly in TypeScript projects with allowImportingTsExtensions #134)
4. This allows us to handle different file extension ([no-missing-imports]: add tryExtensions option #33)

This could be a little finicky to get right 😅 I will give it a go this weekend to see if its plausible!

Edit

The eslint-import-resolver seems to also use enhanced-resolve