fix: change peer dependencies to allow eslint v9 #216
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aladdin-add
force-pushed
the
chore/eslint-v9
branch
from
f0a5180 to
0bc7ec3
Compare
scagood
reviewed
Apr 7, 2024
Comment on lines
+496
to
+530
| // detected duplicate tests by eslint v9 | ||
| // { | ||
| // code: "function f(a = 0) {}", | ||
| // options: [{ version: "5.9.9", ignores: ["defaultParameters"] }], | ||
| // }, | ||
| // { | ||
| // code: "(function(a = 0) {})", | ||
| // options: [{ version: "5.9.9", ignores: ["defaultParameters"] }], | ||
| // }, | ||
| // { | ||
| // code: "((a = 0) => a)", | ||
| // options: [{ version: "5.9.9", ignores: ["defaultParameters"] }], | ||
| // }, | ||
| // { | ||
| // code: "({ key(a = 0) {} })", | ||
| // options: [{ version: "5.9.9", ignores: ["defaultParameters"] }], | ||
| // }, | ||
| // { | ||
| // code: "class A { key(a = 0) {} }", | ||
| // options: [ | ||
| // { | ||
| // version: "5.9.9", | ||
| // ignores: ["classes", "defaultParameters"], | ||
| // }, | ||
| // ], | ||
| // }, | ||
| // { | ||
| // code: "(class { key(a = 0) {} })", | ||
| // options: [ | ||
| // { | ||
| // version: "5.9.9", | ||
| // ignores: ["classes", "defaultParameters"], | ||
| // }, | ||
| // ], | ||
| // }, |
There was a problem hiding this comment.
Can we not leave these here commented out? 👀
There was a problem hiding this comment.
yes, just want to figure out why they are duplicated - maybe a bug somewhere. :)
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.