Skip to content

chore: release latest version #218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 8, 2024
Merged

chore: release latest version #218

merged 2 commits into from
Apr 8, 2024

Conversation

aladdin-add
Copy link

No description provided.

@aladdin-add aladdin-add requested a review from scagood April 7, 2024 03:01
aladdin-add
aladdin-add commented Apr 7, 2024
View reviewed changes
@scagood
Copy link

scagood commented Apr 7, 2024 •
edited
Loading

We also need to remove the next from here: https://github.com/eslint-community/eslint-plugin-n/blob/master/.github/workflows/release-please.yml#L29

If you rename the branch to release-please it will actually run the release please branch.

I am not sure, but I think we may also need to manually remove the -{next.version} from the package 👀
Its worth checking!

@aladdin-add aladdin-add merged commit 9814627 into master Apr 8, 2024
@aladdin-add aladdin-add deleted the chore/release-latest branch April 8, 2024 02:05
@github-actions github-actions bot mentioned this pull request Apr 8, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scagood scagood Awaiting requested review from scagood

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aladdin-add @scagood