Skip to content

Conversation

lumirlumir
Copy link
Member

@lumirlumir lumirlumir commented Aug 3, 2025

Prerequisites checklist

What is the purpose of this pull request?

Hi,

In this PR, I've added the stale.yml workflow.

I referenced the one from the eslint repository: https://github.com/eslint/eslint/blob/main/.github/workflows/stale.yml

I've left a few comments on some key parts of this PR.

What changes did you make? (Give an overview)

I've added the stale.yml workflow.

Related Issues

Ref: #4

Is there anything you'd like reviewers to focus on?

There is a prerequisite for this workflow to function as expected:

  • Is GITHUB_TOKEN secret set at the organization level?

It would be great if these items could be addressed before wrapping up this work!

@lumirlumir lumirlumir added this to Triage Aug 3, 2025
@github-project-automation github-project-automation bot moved this to Needs Triage in Triage Aug 3, 2025
@lumirlumir lumirlumir added the accepted There is consensus among the team that this change meets the criteria for inclusion label Aug 3, 2025
@lumirlumir lumirlumir marked this pull request as ready for review August 3, 2025 08:10
@nzakas
Copy link
Member

nzakas commented Aug 4, 2025

Is GITHUB_TOKEN secret set at the organization level?

GITHUB_TOKEN is autogenerated by workflows.
https://docs.github.com/en/actions/tutorials/authenticate-with-github_token

@nzakas nzakas moved this from Needs Triage to Implementing in Triage Aug 4, 2025
@lumirlumir
Copy link
Member Author

lumirlumir commented Aug 5, 2025

GITHUB_TOKEN is autogenerated by workflows.

Ah, I was confused! Thanks for pointing that out.


Also, I've added a new commit.

@lumirlumir lumirlumir requested a review from nzakas August 5, 2025 13:25
Copy link
Member

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@lumirlumir
Copy link
Member Author

lumirlumir commented Aug 6, 2025

I believe the reason we can't merge this PR is that the branch is out of date.

There is an option to configure this behavior in the repo ruleset, so it might be helpful to take a look at that. (Though I'm not 100% sure.)


Maybe this option?

image

@lumirlumir
Copy link
Member Author

I'm trying to update the branch to the latest.

@lumirlumir
Copy link
Member Author

lumirlumir commented Aug 6, 2025

image

Success. Now, I can see a "Squash and merge" button.

@nzakas nzakas merged commit af9be26 into main Aug 6, 2025
3 checks passed
@nzakas nzakas deleted the feat-create-stale-yml branch August 6, 2025 16:51
@github-project-automation github-project-automation bot moved this from Implementing to Complete in Triage Aug 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion feature
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

2 participants