Skip to content

Conversation

glmnet
Copy link
Member

@glmnet glmnet commented Sep 3, 2025

Description:

This fixes links in properties where it says on_xxx (Automation): blah blah, the Automation link is going to a modbus page which is not the intended place, this fixes it so it works again like the sphinx version

Related issue (if applicable): fixes

Pull request in esphome with YAML changes (if applicable):

  • esphome/esphome#

Checklist:

  • I am merging into next because this is new documentation that has a matching pull-request in esphome as linked above.
    or

  • I am merging into current because this is a fix, change and/or adjustment in the current documentation and is not for a new component or feature.

  • Link added in /components/index.rst when creating new documents for new components or cookbook.

New Component Images

If you are adding a new component to ESPHome, you can automatically generate a standardized black and white component name image for the documentation.

To generate a component image:

  1. Comment on this pull request with the following command, replacing COMPONENT_NAME with your component name in UPPER_CASE format with underscores (e.g., BME280, SHT3X, DALLAS_TEMP):

    @esphomebot generate image COMPONENT_NAME
    
  2. The ESPHome bot will respond with a downloadable ZIP file containing the SVG image.

  3. Extract the SVG file and place it in the images/ folder of this repository.

  4. Use the image in your component's index table entry in /components/index.rst.

Example: For a component called "DHT22 Temperature Sensor", use:

@esphomebot generate image DHT22

@esphome esphome bot added the current label Sep 3, 2025
Copy link

netlify bot commented Sep 3, 2025

Deploy Preview for esphome ready!

Name Link
🔨 Latest commit 42d4abc
🔍 Latest deploy log https://app.netlify.com/projects/esphome/deploys/68b8c7ada66a20000877add1
😎 Deploy Preview https://deploy-preview-5327--esphome.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Contributor

coderabbitai bot commented Sep 3, 2025

Walkthrough

Inserted an anchor shortcode {{< anchor "automation" >}} immediately after the YAML front matter in content/automations/_index.md, adding an "automation" page anchor. Added a blank line following the anchor. No other content modifications.

Changes

Cohort / File(s) Summary of Changes
Content anchor addition
content/automations/_index.md
Inserted page anchor shortcode {{< anchor "automation" >}} after front matter and added a trailing blank line. No other edits.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Suggested labels

current

Suggested reviewers

  • jesserockz
  • clydebarrow
✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore or @coderabbit ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between a113790 and 42d4abc.

📒 Files selected for processing (1)
  • content/automations/_index.md (1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
**

⚙️ CodeRabbit configuration file

  • Do not generate or add any sequence diagrams

Files:

  • content/automations/_index.md
🔇 Additional comments (1)
content/automations/_index.md (1)

10-11: LGTM: anchor restores a stable target for “Automation” references.

Placing {{< anchor "automation" >}} right after the front matter is appropriate and should fix links that intend to point to the top of this page.

Comment on lines +10 to +11
{{< anchor "automation" >}}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Verification agent

🧩 Analysis chain

Verify shortcode syntax and inbound references resolve to #automation.

Please confirm:

  • The repo already uses the same anchor shortcode (with quotes) elsewhere.
  • All “on_xxx (Automation)” references expect .../automations/#automation (exact fragment).

You can run:


🏁 Script executed:

#!/bin/bash
# 1) Survey existing anchor shortcode usage
rg -nC2 $'{{<\\s*anchor\\b' content

# 2) Find inbound references that might need to match the new fragment
rg -nP -C2 '\(Automation\)|#automation\b|/automations/?#' content

# 3) Optional: check for accidental links to Modbus from "(Automation)" mentions
rg -nP -C2 '\(Automation\).*modbus' content

Length of output: 116075


🏁 Script executed:

#!/bin/bash
# 1) List all anchor shortcode usages across the content directory
echo "=== All anchor shortcode usages ==="
rg -nC2 '\{\{<\s*anchor' content

# 2) Detect any anchor shortcode usages without quoted name (possible missing quotes)
echo "=== Anchor usages without quotes ==="
rg -nP '\{\{<\s*anchor\s+[^"]' -n content

Length of output: 270099


Replace page-local “Automation” links with explicit /automations/#automation (or a docref/ref shortcode).

Anchor exists at content/automations/_index.md:10 ({{< anchor "automation" >}}). Many pages (e.g. files under content/components/*) use Automation which is a page-local fragment and will not resolve to the automations page — update those links to /automations/#automation or use the repo's docref/ref shortcode.

🤖 Prompt for AI Agents
In content/automations/_index.md around lines 10-11, the anchor {{< anchor
"automation" >}} is correct but many pages link to it using page-local fragment
links like [Automation](#automation) which won't resolve across pages; update
those references (e.g., files under content/components/* and any other content
using #automation) to use an absolute path or the repo shortcode — either
/automations/#automation or the docref/ref shortcode — so cross-page links
correctly target this anchor.

@glmnet
Copy link
Member Author

glmnet commented Sep 3, 2025

I did it this way so no need to modify all the pages

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant