Skip to content

Conversation

nflaig
Copy link
Member

@nflaig nflaig commented Aug 18, 2025

  • add ssz examples in addition to json
  • add SignedValidatorRegistrationV1 example
  • fix lint warnings due to example/schema mismatches
  • update examples that contained invalid data

Note: I did not reference the ssz examples in the schema itself as swagger doesn't display them correctly, which is a known issue.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bumping beacon-api was required to get rid of lint warnings as some schemas were fixed upstream

@nflaig nflaig changed the title Add ssz examples Add SSZ examples Aug 18, 2025
@bharath-123
Copy link
Collaborator

thanks for this! it would be really nice to have a test script which validates the ssz. Should be easy since we know the types?

@nflaig
Copy link
Member Author

nflaig commented Aug 19, 2025

it would be really nice to have a test script which validates the ssz. Should be easy since we know the types?

It would require to bring in a full ssz library into this repo as the spec right now is not executable. Maybe a script to generate ssz examples from json could be useful but there aren't that many examples so I just manually did it using https://simpleserialize.com/.

@bharath-123
Copy link
Collaborator

For now, reviewers will have to manually verify whether the ssz and json match. Going forward we could figure out a CI action to verify this.

@bharath-123 bharath-123 merged commit 3e8c523 into ethereum:main Aug 21, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants