Skip to content

Conversation

MOSHKA-GOT
Copy link

Description

This PR updates the modal component to improve UX by adding open and close animations for both the modal content and the overlay background.

  • CodeExamples.tsx:

    • Removed conditional rendering of CodeModal to allow close animation before unmounting.
  • dialog-modal.tsx:

    • Replaced animate-contentShow with slide-up and slide-down animations.
    • Added overlay-fade-out animation for smooth background disappearance.
    • Adjusted overlay positioning (grid place-items-end, overflow-hidden).

These changes ensure that when the modal closes, it slides down instead of disappearing abruptly.

Before / After

▶ Before (open/close without smooth close)

1.mp4

▶ After (slide-up on open, slide-down on close, overlay fade)

2.mp4

Copy link

netlify bot commented Aug 15, 2025

Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit cfced77
🔍 Latest deploy log https://app.netlify.com/projects/ethereumorg/deploys/689f2a26e2d4a90007d834e2
😎 Deploy Preview https://deploy-preview-16074--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
7 paths audited
Performance: 54 (no change from production)
Accessibility: 94 (🔴 down 1 from production)
Best Practices: 92 (no change from production)
SEO: 99 (no change from production)
PWA: 59 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@MOSHKA-GOT
Copy link
Author

@chuyeow @matthieu @shazow @fjl Hey team, mind giving this PR a review?

@MOSHKA-GOT
Copy link
Author

@chuyeow @matthieu @shazow @fjl Hello team, would you be able to review this PR?

@wackerow
Copy link
Member

@pettinarip Mind giving this a review from a performance stand point?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants