Skip to content

Conversation

corwintines
Copy link
Member

@corwintines corwintines commented Sep 5, 2025

…g metadata, breadcrumb navigation, and item list details
…etadata, breadcrumb navigation, and community resources details
…uding acknowledgements, contributors, and translatathon leaderboard with metadata and breadcrumb navigation
…adata, breadcrumb navigation, and resource details for tutorials, learning tools, local environment, and main developers page
…metadata, breadcrumb navigation, and publisher information
…ata, breadcrumb navigation, and publisher information
Copy link

netlify bot commented Sep 5, 2025

Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit 9274288
🔍 Latest deploy log https://app.netlify.com/projects/ethereumorg/deploys/68c109edfa79f900086e895b
😎 Deploy Preview https://deploy-preview-16186--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
7 paths audited
Performance: 45 (🟢 up 1 from production)
Accessibility: 96 (🟢 up 1 from production)
Best Practices: 92 (🔴 down 8 from production)
SEO: 92 (no change from production)
PWA: 59 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions github-actions bot added the tooling 🔧 Changes related to tooling of the project label Sep 5, 2025
Copy link
Member

@pettinarip pettinarip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@corwintines maybe a late comment on this work but was wondering if we could abstract this code in a separate file to avoid adding too many things in each file and see if we can avoid some duplication

new-page/
├─ page.tsx
├─ page-jsonld.ts // exports an adapted PageJsonLD component to be used in page.tsx

components/
├─ PageJsonLD.tsx // generic component that prints the `script` tags

We could set a pattern for all pages to look like this.

At the page level

import PageJsonLD from "./page-jsonld"

return (
  <PageJsonLD {...frontmatter} />

  ...rest
)

===
related issue to the mindset I had for this implementation.

@github-actions github-actions bot added content 🖋️ This involves copy additions or edits translation 🌍 This is related to our Translation Program labels Sep 10, 2025
Copy link
Member

@pettinarip pettinarip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@corwintines I've found two small issues. The rest looks great 👍🏼

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

orphan?

"@id": "https://ethereum.org",
name: "ethereum.org",
url: "https://ethereum.org",
logo: "https://ethereum.org/images/ethereum-logo.png",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This image doesn't exist. Maybe https://ethereum.org/images/eth-org-logo.png?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noted that this one fails because this is used inside a client component. We need to use useTranslations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content 🖋️ This involves copy additions or edits tooling 🔧 Changes related to tooling of the project translation 🌍 This is related to our Translation Program
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants