Add EIP-7981 Implementation #1384
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gurukamath
reviewed
Sep 1, 2025
src/ethereum/osaka/transactions.py
Outdated
|
|
||
| for access in access_list: | ||
| # Count bytes in address (20 bytes) | ||
| for byte in access.account: |
There was a problem hiding this comment.
Counting zero and non-zero bytes is being used in a couple of other places as well, including for call data in calculate_intrinsic_cost. Perhaps it would be a good idea to refactor it into a function in the ethereum.utils.byte module.
There was a problem hiding this comment.
yeah agree, makes sense
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First draft implementation of EIP-7981, which is going to be proposed for Glamsterdam.