Skip to content

Conversation

shanefontaine
Copy link

What was wrong?

Docs for tx receipt need updating to reflect EIP-658.

How was it fixed?

Added status and logsBloom to Eth.getTransactionReceipt() and Eth. waitForTransactionReceipt(). Removed deprecated root.

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@shanefontaine shanefontaine changed the title docs: return status and logsBloom in tx receipt. remove root attribute. docs: Return status and logsBloom in tx receipt. Remove root attribute. Minor wording fixes. Jan 4, 2019
'gasUsed': 21000,
'logs': [],
'root': '96a8e009d2b88b1483e6941e6812e32263b05683fac202abc622a3e31aed1957',
'logsBloom': '0x0000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This error seems like it could be caught were these code blocks to be doctested. Is that something you'd be up for adding? It should be reasonably simple, though it will require setting up a bit of chain state in a .. testsetup block.

Copy link
Author

@shanefontaine shanefontaine Jan 4, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pipermerriam when you get a chance, can you take a look at 72d4098. I believe that does what we want. I didn't use a .. testsetup block, so I am not sure I accomplished exactly what you want.

I skipped the "not yet mined" line in the doctest on 383ee34 because I don't think it is possible to always have a pending tx to pull from for the docs. It was giving me:

**********************************************************************
File "web3.eth.rst", line 419, in default
Failed example:
    w3.eth.getTransactionReceipt('0xf5fb3ce9c0fce91dd3d112c2ab63f9d1800f6f70667d0c4481fd72d573e12345')  # not yet mined
Expected:
    None
    # wait for it to be mined....
Got nothing
**********************************************************************

It is passing locally but CircleCI is failing here with web3.exceptions.UnhandledRequest: No providers responded to the RPC reque. This is weird, because the web3 setup seems identical to the rest of the docs. Any idea there?

@pacrob
Copy link
Contributor

pacrob commented Feb 4, 2022

Closing due to age, docs have been updated since.

@pacrob pacrob closed this Feb 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants