Skip to content

idris uses slug #1192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 27, 2025
Merged

idris uses slug #1192

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3baa597
idris uses slug
keiravillekode May 22, 2025
1f81586
Obtain exercise slug from metadata
keiravillekode May 26, 2025
b814c83
TestIdrisUsesExerciseSlug
keiravillekode May 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion workspace/test_configurations.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,13 @@ func (c *TestConfiguration) GetTestCommand() (string, error) {
}
cmd = strings.ReplaceAll(cmd, "{{test_files}}", strings.Join(testFiles, " "))
}
if strings.Contains(cmd, "{{slug}}") {
metadata, err := NewExerciseMetadata(".")
if err != nil {
return "", err
}
cmd = strings.ReplaceAll(cmd, "{{slug}}", metadata.ExerciseSlug)
}

return cmd, nil
}
Expand Down Expand Up @@ -152,7 +159,7 @@ var TestConfigurations = map[string]TestConfiguration{
Command: "stack test",
},
"idris": {
Command: "pack test `basename *.ipkg .ipkg`",
Command: "pack test {{slug}}",
},
"j": {
Command: `jconsole -js "exit echo unittest {{test_files}} [ load {{solution_files}}"`,
Expand Down
40 changes: 40 additions & 0 deletions workspace/test_configurations_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,3 +101,43 @@ func TestRustHasTrailingDashes(t *testing.T) {

assert.True(t, strings.HasSuffix(cmd, "--"), "rust's test command should have trailing dashes")
}

func TestIdrisUsesCurrentDirectory(t *testing.T) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
func TestIdrisUsesCurrentDirectory(t *testing.T) {
func TestIdrisUsesExerciseSlug(t *testing.T) {

currentDir, err := os.Getwd()
assert.NoError(t, err)

tmpDir, err := os.MkdirTemp("", "solution")
assert.NoError(t, err)
defer os.RemoveAll(tmpDir)

em := &ExerciseMetadata{
Track: "idris",
ExerciseSlug: "bogus-exercise",
ID: "abc",
URL: "http://example.com",
Handle: "alice",
IsRequester: true,
Dir: tmpDir,
}
err = em.Write(tmpDir)
assert.NoError(t, err)

defer os.Chdir(currentDir)
err = os.Chdir(tmpDir)
assert.NoError(t, err)

exercismDir := filepath.Join(".", ".exercism")
f, err := os.Create(filepath.Join(exercismDir, "config.json"))
assert.NoError(t, err)
defer f.Close()

_, err = f.WriteString(`{ "files": { "solution": [ "src/BogusExercise.idr" ], "test": [ "test/src/Main.idr" ] } }`)
assert.NoError(t, err)

testConfig, ok := TestConfigurations["idris"]
assert.True(t, ok, "unexpectedly unable to find idris test config")

cmd, err := testConfig.GetTestCommand()
assert.NoError(t, err)
assert.Equal(t, cmd, "pack test bogus-exercise")
}
Loading