-
-
Notifications
You must be signed in to change notification settings - Fork 724
Related to #2971 display names #3000
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Related to #2971 display names #3000
Conversation
This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested. If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos.
For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work, @bibekparajuli123!
Just a couple of small nits to address.
import org.junit.jupiter.api.DisplayName; | ||
import org.junit.jupiter.api.Test; | ||
import org.junit.jupiter.api.Disabled; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
import org.junit.jupiter.api.DisplayName; | |
import org.junit.jupiter.api.Test; | |
import org.junit.jupiter.api.Disabled; | |
import org.junit.jupiter.api.Disabled; | |
import org.junit.jupiter.api.DisplayName; | |
import org.junit.jupiter.api.Test; |
Can you also move this up, so the imports are nicely arranged in a alphabetical order?
import org.junit.jupiter.api.BeforeEach; | ||
import org.junit.jupiter.api.DisplayName; | ||
import org.junit.jupiter.api.Test; | ||
import org.junit.jupiter.api.Disabled; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
import org.junit.jupiter.api.BeforeEach; | |
import org.junit.jupiter.api.DisplayName; | |
import org.junit.jupiter.api.Test; | |
import org.junit.jupiter.api.Disabled; | |
import org.junit.jupiter.api.BeforeEach; | |
import org.junit.jupiter.api.Disabled; | |
import org.junit.jupiter.api.DisplayName; | |
import org.junit.jupiter.api.Test; |
This one too!
import org.junit.jupiter.api.BeforeEach; | ||
import org.junit.jupiter.api.DisplayName; | ||
import org.junit.jupiter.api.Test; | ||
import org.junit.jupiter.api.Disabled; | ||
import static org.assertj.core.api.Assertions.assertThat; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
import org.junit.jupiter.api.BeforeEach; | |
import org.junit.jupiter.api.DisplayName; | |
import org.junit.jupiter.api.Test; | |
import org.junit.jupiter.api.Disabled; | |
import static org.assertj.core.api.Assertions.assertThat; | |
import org.junit.jupiter.api.BeforeEach; | |
import org.junit.jupiter.api.Disabled; | |
import org.junit.jupiter.api.DisplayName; | |
import org.junit.jupiter.api.Test; | |
import static org.assertj.core.api.Assertions.assertThat; |
|
@@ -194,6 +201,7 @@ public void testComplexGraphNoShortcutFarRemovedNephew() { | |||
|
|||
@Disabled("Remove to run test") | |||
@Test | |||
@DisplayName("Complex graph, some shortcuts, cross-down and cross-up, cousins several times removed, with unrelated family tree") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DisplayName("Complex graph, some shortcuts, cross-down and cross-up, cousins several times removed, with unrelated family tree") | |
@DisplayName( | |
"Complex graph, some shortcuts, cross-down and cross-up, " + | |
"cousins several times removed, with unrelated family tree" | |
) |
This change will fix the checkstyle error. The line length needs to be under 120 characters, which is why the tests were failing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for catching this! I've fixed the long display name by breaking it into multiple lines as suggested.
The checkstyle error should now be resolved. Thanks for the guidance!
pull request
Description
Add @DisplayName annotations to test methods based on canonical data
Changes
Added DisplayName annotations to the following exercises:
Testing
All tests pass successfully (verified with ./gradlew test)
Related Issue
Addresses #2971 (DisplayName annotations initiative)
Reviewer Resources:
Track Policies