Fix exercise naming in generator #1770
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t file naming convention
kotp
approved these changes
Aug 30, 2025
bin/generate
Outdated
| @@ -9,6 +9,10 @@ def exercises | |||
| .select { |file| File.directory? File.join('./exercises/practice', file) } | |||
| end | |||
|
|
|||
| def underscore(str) | |||
| str.gsub(/[^a-zA-Z0-9_-]/, '').gsub(/[-\s]/, '_').downcase | |||
There was a problem hiding this comment.
Should this use the character class instead of listing these, or is this limited to only the mentioned characters?
There was a problem hiding this comment.
Good point, I don't write regex that often, so I am not that good at it. Likely something I should work on.
generatorv2/lib/generator.rb
Outdated
| end | ||
|
|
||
| def underscore(str) | ||
| str.gsub(/[-\s]/, '_').downcase | ||
| str.gsub(/[^a-zA-Z0-9_\- ]/, '').gsub(/[-\s]/, '_').downcase |
There was a problem hiding this comment.
Should we use a character class here as well?
kotp
approved these changes
Aug 31, 2025
meatball133
added a commit
that referenced
this pull request
Aug 31, 2025
* Enhance underscore method to filter invalid characters and update test file naming convention * Add test case which test underscore for special characters * Use character classes in regex. Also expose description for nested test cases. * Underscore must not create multiple underscores around special characters
meatball133
added a commit
that referenced
this pull request
Aug 31, 2025
* Enhance underscore method to filter invalid characters and update test file naming convention * Add test case which test underscore for special characters * Use character classes in regex. Also expose description for nested test cases. * Underscore must not create multiple underscores around special characters
meatball133
added a commit
that referenced
this pull request
Aug 31, 2025
* Enhance underscore method to filter invalid characters and update test file naming convention * Add test case which test underscore for special characters * Use character classes in regex. Also expose description for nested test cases. * Underscore must not create multiple underscores around special characters
kotp
added a commit
that referenced
this pull request
Aug 31, 2025
* Make test name unique in allergies * Changed exercises to use single quotes. Changed template for allergies so it should match the old version. * Update acronym solution to work on the new test * Fix import and class in atbash test * Fix exercise naming in generator (#1770) (#1774) * Enhance underscore method to filter invalid characters and update test file naming convention * Add test case which test underscore for special characters * Use character classes in regex. Also expose description for nested test cases. * Underscore must not create multiple underscores around special characters --------- Co-authored-by: Victor Goff <[email protected]>
meatball133
added a commit
that referenced
this pull request
Aug 31, 2025
* Fix exercise naming in generator (#1770) * Enhance underscore method to filter invalid characters and update test file naming convention * Add test case which test underscore for special characters * Use character classes in regex. Also expose description for nested test cases. * Underscore must not create multiple underscores around special characters * Add templates to exercises batch 1 (#1771) * Make test name unique in allergies * Changed exercises to use single quotes. Changed template for allergies so it should match the old version. * Update acronym solution to work on the new test * Fix import and class in atbash test * Fix exercise naming in generator (#1770) (#1774) * Enhance underscore method to filter invalid characters and update test file naming convention * Add test case which test underscore for special characters * Use character classes in regex. Also expose description for nested test cases. * Underscore must not create multiple underscores around special characters --------- Co-authored-by: Victor Goff <[email protected]> --------- Co-authored-by: Victor Goff <[email protected]>
meatball133
added a commit
that referenced
this pull request
Sep 3, 2025
* Update bob and change and book store * Add templates for bottlesong, bowling,clock and collatz conjecture * Fix exercise naming in generator (#1770) (#1776) * Enhance underscore method to filter invalid characters and update test file naming convention * Add test case which test underscore for special characters * Use character classes in regex. Also expose description for nested test cases. * Underscore must not create multiple underscores around special characters * Fix formatting * Add EOL
kotp
pushed a commit
that referenced
this pull request
Sep 7, 2025
* Add templates for exercises batch 3 * Fix exercise naming in generator (#1770) (#1777) * Enhance underscore method to filter invalid characters and update test file naming convention * Add test case which test underscore for special characters * Use character classes in regex. Also expose description for nested test cases. * Underscore must not create multiple underscores around special characters * Change to single quotes, change conditional statement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fix for the exercise name was only applied for the generator not the bin script. The underscore method in the generator will now clear all characters which is not numbers or letters. Noticed this would conflict when a description on problem spec had for example "," in it. Further, are there some formatting changes to make so it formats the files correctly.