Skip to content

Conversation

lemonade-37
Copy link
Contributor

Typos in the Moviegoer documentation file have been corrected.
Please review.

Reference:

Copy link
Contributor

github-actions bot commented Sep 1, 2025

Hello. Thanks for opening a PR on Exercism 🙂

We ask that all changes to Exercism are discussed on our Community Forum before being opened on GitHub. To enforce this, we automatically close all PRs that are submitted. That doesn't mean your PR is rejected but that we want the initial discussion about it to happen on our forum where a wide range of key contributors across the Exercism ecosystem can weigh in.

You can use this link to copy this into a new topic on the forum. If we decide the PR is appropriate, we'll reopen it and continue with it, so please don't delete your local branch.

If you're interested in learning more about this auto-responder, please read this blog post.


Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it.

@github-actions github-actions bot closed this Sep 1, 2025
@kotp kotp reopened this Sep 1, 2025
@@ -24,7 +24,7 @@ The cinema has a simplified age-verification system.
If you are 18 or over you can watch scary movies.
If you are younger, you cannot.

Implement the `Moviegoer.watch_scary_movie?` method.
Implement the `Moviegoer#watch_scary_movie?` method.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not a typographical error, it is as intended. The method called is an instance method, as we can see and verify from the tests:

def test_regular_ticket_price
  assert_equal 15, Moviegoer.new(59).ticket_price
end

Copy link
Contributor Author

@lemonade-37 lemonade-37 Sep 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since it was originally documented within exercises/concept/moviegoer/moviegoer.rb, I believe “Moviegoer#watch_scary_movie” is correct. What do you think?

  def watch_scary_movie?
    raise 'Please implement the Moviegoer#watch_scary_movie method'
  end

Additionally, instance methods of the same format are also written using “#” in the problem statement.
Therefore, I thought it would be better to standardize the notation for instance methods.

Write the Moviegoer#ticket_price method using a ternary statement.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know for a fact that it is correct. Class#method_name is for instance methods and Class.method_name, as well as the less used Class::method_name is for class methods. The first example is not usable invocable code, but is how we have documented Ruby code since well before 1.8.5.

@@ -6,7 +6,7 @@

## 2. Check if a moviegoer is allowed to see scary movies

- [Compare][doc-integer-gtoe] the moviegoer's age with the minimum age allowed to see scary movies. You don't even need thee ternary operator in this task.
- [Compare][doc-integer-gtoe] the moviegoer's age with the minimum age allowed to see scary movies. You don't even need the ternary operator in this task.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is good.

@kotp
Copy link
Member

kotp commented Sep 1, 2025

Sorry for the noise, we are saying the same thing, I am being round-about with it, and did not realize it.

@kotp kotp merged commit cc9244b into exercism:main Sep 1, 2025
7 checks passed
@lemonade-37
Copy link
Contributor Author

@kotp
I'm sorry I wasn't very good at English and didn't fully understand your intentions.
Thank you so much for handling the review this time!

@lemonade-37 lemonade-37 deleted the fix-typo-in-moviegoer branch September 4, 2025 04:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants