Skip to content

Conversation

quintuple-mallard
Copy link
Contributor

@quintuple-mallard quintuple-mallard commented Aug 28, 2025

Sorry about the not very informative commit messages. I realised a little too late that someone would be reading them.

@quintuple-mallard quintuple-mallard requested a review from a team as a code owner August 28, 2025 18:35
Copy link

Hello. Thanks for opening a PR on Exercism 🙂

We ask that all changes to Exercism are discussed on our Community Forum before being opened on GitHub. To enforce this, we automatically close all PRs that are submitted. That doesn't mean your PR is rejected but that we want the initial discussion about it to happen on our forum where a wide range of key contributors across the Exercism ecosystem can weigh in.

You can use this link to copy this into a new topic on the forum. If we decide the PR is appropriate, we'll reopen it and continue with it, so please don't delete your local branch.

If you're interested in learning more about this auto-responder, please read this blog post.


Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it.

@github-actions github-actions bot closed this Aug 28, 2025
@SleeplessByte SleeplessByte reopened this Aug 29, 2025
@SleeplessByte
Copy link
Member

@quintuple-mallard we can just squash merge at the end if you want so the commits go to "normal" message.

@SleeplessByte

This comment was marked as resolved.

Copy link
Member

@ErikSchierboom ErikSchierboom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you look at the docs, you'll see that comments can also have different types: https://exercism.org/docs/building/tooling/analyzers/interface Would that be possible to incorporate here too?

@quintuple-mallard
Copy link
Contributor Author

Ok, how about actionable for warnings and informative for others?

@ErikSchierboom
Copy link
Member

Great!

@quintuple-mallard
Copy link
Contributor Author

Implemented.

Copy link
Member

@ErikSchierboom ErikSchierboom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One tiny nit!

p.s. I've merged exercism/website-copy#2388

Copy link
Member

@ErikSchierboom ErikSchierboom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! I'll need to do some maintenance work to get this integrated. Bear with me for a bit

@ErikSchierboom
Copy link
Member

@quintuple-mallard could you maybe update the Uiua version that's installed to the one used in the test runner: https://github.com/exercism/uiua-test-runner/blob/main/Dockerfile?

@ErikSchierboom ErikSchierboom merged commit 1baf388 into exercism:main Sep 2, 2025
1 check passed
@ErikSchierboom
Copy link
Member

I'm waiting for some infrastructure work to enable this in production.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants