-
-
Notifications
You must be signed in to change notification settings - Fork 3
Add analyzer. #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Analyzer uses `uiua run` to make style comments, advice, and warnings
This reverts commit 8dc5f1d.
Hello. Thanks for opening a PR on Exercism 🙂 We ask that all changes to Exercism are discussed on our Community Forum before being opened on GitHub. To enforce this, we automatically close all PRs that are submitted. That doesn't mean your PR is rejected but that we want the initial discussion about it to happen on our forum where a wide range of key contributors across the Exercism ecosystem can weigh in. You can use this link to copy this into a new topic on the forum. If we decide the PR is appropriate, we'll reopen it and continue with it, so please don't delete your local branch. If you're interested in learning more about this auto-responder, please read this blog post. Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it. |
@quintuple-mallard we can just squash merge at the end if you want so the commits go to "normal" message. |
This comment was marked as resolved.
This comment was marked as resolved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you look at the docs, you'll see that comments can also have different types: https://exercism.org/docs/building/tooling/analyzers/interface Would that be possible to incorporate here too?
Ok, how about |
Great! |
Implemented. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One tiny nit!
p.s. I've merged exercism/website-copy#2388
Co-authored-by: Erik Schierboom <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! I'll need to do some maintenance work to get this integrated. Bear with me for a bit
@quintuple-mallard could you maybe update the Uiua version that's installed to the one used in the test runner: https://github.com/exercism/uiua-test-runner/blob/main/Dockerfile? |
I'm waiting for some infrastructure work to enable this in production. |
Sorry about the not very informative commit messages. I realised a little too late that someone would be reading them.