Support TS 5.0 ModuleResolutionKind
#439
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
it works with the final version |
agilgur5
added
solution: tsc behavior
|
Fixed upstream in microsoft/TypeScript#53131 / microsoft/TypeScript#53139 |
agilgur5
added
the
kind: regression
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add support for TS5.0 by using ModuleResolutionKind.Node10 if ModuleResolutionKind.NodeJs is not found
Fixes #436
Details
TS5 renamed ModuleResolutionKind.NodeJs to Node10, so the first one returns undefined, which actually means Classic module resolution
I had to use as any for it to compile. If this project ever uses TS5 as devDependency then the as any will probably need to be reversed.