Skip to content

Fix component name for React.lazy #13443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 20, 2018
Merged

Fix component name for React.lazy #13443

merged 2 commits into from
Aug 20, 2018

Conversation

gaearon
Copy link
Collaborator

@gaearon gaearon commented Aug 20, 2018

@gaearon gaearon requested review from acdlite and bvaughn August 20, 2018 15:36
bvaughn
bvaughn approved these changes Aug 20, 2018
View reviewed changes
Copy link
Contributor

@bvaughn bvaughn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unused import left, but otherwise 👍

packages/shared/getComponentName.js
const thenable: Thenable<mixed> = (type: any);
const resolvedThenable = refineResolvedThenable(thenable);
if (resolvedThenable) {
const Component = getResultFromResolvedThenable(resolvedThenable);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was the only reference to getResultFromResolvedThenable

@gaearon gaearon merged commit 973496b into facebook:master Aug 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acdlite acdlite Awaiting requested review from acdlite

1 more reviewer

@bvaughn bvaughn bvaughn approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gaearon @bvaughn @facebook-github-bot