Skip to content

SuspenseList: Reschedule continuation at same priority #18738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 26, 2020
Merged

SuspenseList: Reschedule continuation at same priority #18738

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 3 additions & 9 deletions packages/react-reconciler/src/ReactFiberCompleteWork.new.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,11 +127,7 @@ import {
renderHasNotSuspendedYet,
} from './ReactFiberWorkLoop.new';
import {createFundamentalStateInstance} from './ReactFiberFundamental.new';
import {
Never,
isSameOrHigherPriority,
bumpPriorityLower,
} from './ReactFiberExpirationTime.new';
import {Never, isSameOrHigherPriority} from './ReactFiberExpirationTime.new';
import {resetChildFibers} from './ReactChildFiber.new';
import {updateDeprecatedEventListeners} from './ReactFiberDeprecatedEvents.new';
import {createScopeMethods} from './ReactFiberScope.new';
Expand Down Expand Up @@ -1118,11 +1114,9 @@ function completeWork(
// them, then they really have the same priority as this render.
// So we'll pick it back up the very next render pass once we've had
// an opportunity to yield for paint.

const nextPriority = bumpPriorityLower(renderExpirationTime);
workInProgress.expirationTime_opaque = workInProgress.childExpirationTime_opaque = nextPriority;
workInProgress.expirationTime_opaque = renderExpirationTime;
if (enableSchedulerTracing) {
markSpawnedWork(nextPriority);
markSpawnedWork(renderExpirationTime);
}
}
}
Expand Down