Skip to content

Conversation

bvaughn
Copy link
Contributor

@bvaughn bvaughn commented Apr 14, 2021

This regressed in #21238 so that yarn test-build-devtools no longer ran.

@bvaughn bvaughn requested review from rickhanlonii and acdlite April 14, 2021 17:42
@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Apr 14, 2021
@sizebot
Copy link

sizebot commented Apr 14, 2021

Comparing: 6b3d86a...69c66f0

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 122.68 kB 122.68 kB = 39.38 kB 39.38 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 129.25 kB 129.25 kB = 41.46 kB 41.46 kB
facebook-www/ReactDOM-prod.classic.js = 412.18 kB 412.18 kB = 76.23 kB 76.23 kB
facebook-www/ReactDOM-prod.modern.js = 400.23 kB 400.23 kB = 74.32 kB 74.32 kB
facebook-www/ReactDOMForked-prod.classic.js = 412.18 kB 412.18 kB = 76.23 kB 76.23 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against 69c66f0

@bvaughn
Copy link
Contributor Author

bvaughn commented Apr 16, 2021

Going to merge this for now b'c I have to keep patching my local branches to run the DevTools test command :) Let me know if you'd like follow up changes.

@bvaughn bvaughn merged commit c3cb2c2 into facebook:master Apr 16, 2021
@bvaughn bvaughn deleted the fix-devtools-test-target branch April 16, 2021 20:19
koto pushed a commit to koto/react that referenced this pull request Jun 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants