Fix use of hydrateRoot in DevTools test #24084
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I noticed while working on a different PR that this test was not using hydrateRoot correctly. You're meant to pass the initial children as the second argument.
facebook-github-bot
added
CLA Signed
React Core Team
sebmarkbage
approved these changes
Mar 12, 2022
eps1lon
reviewed
Mar 13, 2022
| const container = document.createElement('div'); | ||
| container.innerHTML = '<div></div>'; | ||
| ReactDOMClient.hydrateRoot(container).render(<Example />); | ||
| ReactDOMClient.hydrateRoot(container, <Example />); |
There was a problem hiding this comment.
My initial reaction was that I'm glad I'm not the only one who gets this wrong. But it was me 😅
3 tasks
|
Thanks for the fix. |
zhengjitf
pushed a commit
to zhengjitf/react
that referenced
this pull request
Apr 15, 2022
I noticed while working on a different PR that this test was not using hydrateRoot correctly. You're meant to pass the initial children as the second argument.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed while working on a different PR that this test was not using hydrateRoot correctly. You're meant to pass the initial children as the second argument.