Clean up experimental flags #28116

rickhanlonii · 2024-01-26T20:04:07Z

Overview

Adds a new global to disambiguate experimental flags that we intend to land when we can make breaking changes.

react-sizebot · 2024-01-26T20:10:16Z

Comparing: 9aef5d2...ad10c63

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name	+/-	Base	Current	+/- gzip	Base gzip	Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js	=	176.59 kB	176.59 kB	=	55.01 kB	55.01 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js	=	178.69 kB	178.69 kB	=	55.64 kB	55.64 kB
facebook-www/ReactDOM-prod.classic.js	=	573.52 kB	573.52 kB	=	100.99 kB	100.99 kB
facebook-www/ReactDOM-prod.modern.js	=	557.29 kB	557.29 kB	=	98.07 kB	98.07 kB
test_utils/ReactAllWarnings.js	Deleted	67.55 kB	0.00 kB	Deleted	16.54 kB	0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show

Name	+/-	Base	Current	+/- gzip	Base gzip	Current gzip
test_utils/ReactAllWarnings.js	Deleted	67.55 kB	0.00 kB	Deleted	16.54 kB	0.00 kB

Generated by 🚫 dangerJS against ad10c63

rickhanlonii · 2024-01-26T21:25:43Z

packages/shared/ReactFeatureFlags.js

+// Modern <StrictMode /> behaviour aligns more with what components
+// components will encounter in production, especially when used With <Offscreen />.
+// TODO: clean up legacy <StrictMode /> once tests pass WWW.
+export const useModernStrictMode = false;


I'll turn these on in experimental in follow up PRs.

sebmarkbage · 2024-01-29T18:06:03Z

scripts/rollup/build.js

@@ -468,6 +470,7 @@ function getPlugins(
            ? "'production'"
            : "'development'",
          __EXPERIMENTAL__,
+          __NEXT_MAJOR__,


Instead of setting this up as a global I was suggesting that it would just be a constant inside ReactFeatureFlags.js so that it doesn't leak. Since it's a temporary state it's annoying to go around update tests and other things that might be flagged on this.

## Overview Depends on: #28116 Add `yarn flags` to output at table of all feature flags. Provides options to output a csv file, diff two or more builds, and sort. ### Options <img width="1154" alt="Screenshot 2024-01-26 at 4 06 53 PM" src="https://github.com/facebook/react/assets/2440089/c3dbd632-adb9-4416-9488-1c603ee4e789"> ### `yarn flags --diff next canary` <img width="637" alt="Screenshot 2024-01-26 at 4 15 03 PM" src="https://github.com/facebook/react/assets/2440089/1a681ae8-ce33-42d0-9d1f-3f415a8e1c3d"> ### `yarn flags --diff canary experimental` <img width="637" alt="Screenshot 2024-01-26 at 4 14 51 PM" src="https://github.com/facebook/react/assets/2440089/c66f66cb-3cee-4df6-a1d1-b24600ebd4b3"> ### `yarn flags` (all flags) <img width="1054" alt="Screenshot 2024-01-26 at 4 16 30 PM" src="https://github.com/facebook/react/assets/2440089/4ce99c7c-825e-4bca-9b83-ca5d6e2bc1a9">

## Overview Adds a new global to disambiguate experimental flags that we intend to land when we can make breaking changes.

## Overview Depends on: #28116 Add `yarn flags` to output at table of all feature flags. Provides options to output a csv file, diff two or more builds, and sort. ### Options <img width="1154" alt="Screenshot 2024-01-26 at 4 06 53 PM" src="https://github.com/facebook/react/assets/2440089/c3dbd632-adb9-4416-9488-1c603ee4e789"> ### `yarn flags --diff next canary` <img width="637" alt="Screenshot 2024-01-26 at 4 15 03 PM" src="https://github.com/facebook/react/assets/2440089/1a681ae8-ce33-42d0-9d1f-3f415a8e1c3d"> ### `yarn flags --diff canary experimental` <img width="637" alt="Screenshot 2024-01-26 at 4 14 51 PM" src="https://github.com/facebook/react/assets/2440089/c66f66cb-3cee-4df6-a1d1-b24600ebd4b3"> ### `yarn flags` (all flags) <img width="1054" alt="Screenshot 2024-01-26 at 4 16 30 PM" src="https://github.com/facebook/react/assets/2440089/4ce99c7c-825e-4bca-9b83-ca5d6e2bc1a9">

## Overview Adds a new global to disambiguate experimental flags that we intend to land when we can make breaking changes.

## Overview Depends on: facebook#28116 Add `yarn flags` to output at table of all feature flags. Provides options to output a csv file, diff two or more builds, and sort. ### Options <img width="1154" alt="Screenshot 2024-01-26 at 4 06 53 PM" src="https://github.com/facebook/react/assets/2440089/c3dbd632-adb9-4416-9488-1c603ee4e789"> ### `yarn flags --diff next canary` <img width="637" alt="Screenshot 2024-01-26 at 4 15 03 PM" src="https://github.com/facebook/react/assets/2440089/1a681ae8-ce33-42d0-9d1f-3f415a8e1c3d"> ### `yarn flags --diff canary experimental` <img width="637" alt="Screenshot 2024-01-26 at 4 14 51 PM" src="https://github.com/facebook/react/assets/2440089/c66f66cb-3cee-4df6-a1d1-b24600ebd4b3"> ### `yarn flags` (all flags) <img width="1054" alt="Screenshot 2024-01-26 at 4 16 30 PM" src="https://github.com/facebook/react/assets/2440089/4ce99c7c-825e-4bca-9b83-ca5d6e2bc1a9">

## Overview Adds a new global to disambiguate experimental flags that we intend to land when we can make breaking changes. DiffTrain build for commit 4d6c47b.

## Overview Depends on: facebook/react#28116 Add `yarn flags` to output at table of all feature flags. Provides options to output a csv file, diff two or more builds, and sort. ### Options <img width="1154" alt="Screenshot 2024-01-26 at 4 06 53 PM" src="https://github.com/facebook/react/assets/2440089/c3dbd632-adb9-4416-9488-1c603ee4e789"> ### `yarn flags --diff next canary` <img width="637" alt="Screenshot 2024-01-26 at 4 15 03 PM" src="https://github.com/facebook/react/assets/2440089/1a681ae8-ce33-42d0-9d1f-3f415a8e1c3d"> ### `yarn flags --diff canary experimental` <img width="637" alt="Screenshot 2024-01-26 at 4 14 51 PM" src="https://github.com/facebook/react/assets/2440089/c66f66cb-3cee-4df6-a1d1-b24600ebd4b3"> ### `yarn flags` (all flags) <img width="1054" alt="Screenshot 2024-01-26 at 4 16 30 PM" src="https://github.com/facebook/react/assets/2440089/4ce99c7c-825e-4bca-9b83-ca5d6e2bc1a9"> DiffTrain build for commit facebook/react@45582c6.

rickhanlonii requested a review from sebmarkbage January 26, 2024 20:04

facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Jan 26, 2024

Clean up experimental flags and turn some on

76f14eb

rickhanlonii force-pushed the rh/next-major branch from a97486a to 76f14eb Compare January 26, 2024 20:06

rickhanlonii mentioned this pull request Jan 26, 2024

Add script to output flag values #28115

Merged

dont' turn the flags on yet

2669eef

rickhanlonii changed the title ~~Clean up experimental flags and turn some on~~ Clean up experimental flags Jan 26, 2024

rickhanlonii commented Jan 26, 2024

View reviewed changes

sebmarkbage reviewed Jan 29, 2024

View reviewed changes

Just inline it

12aa92c

rickhanlonii force-pushed the rh/next-major branch from 3512ffb to 12aa92c Compare January 29, 2024 18:42

Revert webpack.backend.js change

ad10c63

rickhanlonii requested a review from sebmarkbage January 29, 2024 18:44

jackpope approved these changes Jan 29, 2024

View reviewed changes

rickhanlonii merged commit 4d6c47b into facebook:main Jan 29, 2024

rickhanlonii deleted the rh/next-major branch January 29, 2024 19:03

gnoff mentioned this pull request Feb 1, 2024

Update React from 60a927d04 to 2bc7d336a vercel/next.js#61522

Merged

gaearon pushed a commit that referenced this pull request Feb 3, 2024

Clean up experimental flags (#28116)

2eeca93

## Overview Adds a new global to disambiguate experimental flags that we intend to land when we can make breaking changes.

ztanner mentioned this pull request Mar 19, 2024

(backport) Update React from 60a927d04 to 14898b6a9 vercel/next.js#63442

Closed

EdisonVan pushed a commit to EdisonVan/react that referenced this pull request Apr 15, 2024

Clean up experimental flags (facebook#28116)

4a0aa11

## Overview Adds a new global to disambiguate experimental flags that we intend to land when we can make breaking changes.

bigfootjon pushed a commit that referenced this pull request Apr 18, 2024

Clean up experimental flags (#28116)

68cf918

## Overview Adds a new global to disambiguate experimental flags that we intend to land when we can make breaking changes. DiffTrain build for commit 4d6c47b.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Clean up experimental flags #28116

Clean up experimental flags #28116

Uh oh!

rickhanlonii commented Jan 26, 2024 •

edited

Loading

Uh oh!

react-sizebot commented Jan 26, 2024 •

edited

Loading

Uh oh!

rickhanlonii Jan 26, 2024

Uh oh!

sebmarkbage Jan 29, 2024

Uh oh!

rickhanlonii Jan 29, 2024

Uh oh!

Uh oh!

Clean up experimental flags #28116

Clean up experimental flags #28116

Uh oh!

Conversation

rickhanlonii commented Jan 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Overview

Uh oh!

react-sizebot commented Jan 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Critical size changes

Significant size changes

Uh oh!

rickhanlonii Jan 26, 2024

Choose a reason for hiding this comment

Uh oh!

sebmarkbage Jan 29, 2024

Choose a reason for hiding this comment

Uh oh!

rickhanlonii Jan 29, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

rickhanlonii commented Jan 26, 2024 •

edited

Loading

react-sizebot commented Jan 26, 2024 •

edited

Loading