Skip to content

[tests] add assertConsole<method>Dev helpers #28732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 11, 2024
Merged

[tests] add assertConsole<method>Dev helpers #28732

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
a40a5e5
Move console mocks to internal-test-utils
rickhanlonii Apr 1, 2024
b2866b1
[tests] Add assertWarnDev, assertErrorDev, assertLogDev
rickhanlonii Apr 3, 2024
70088cb
assert console cleared before act
rickhanlonii Apr 3, 2024
a7750f8
Assert logs cleared when assertYieldsWereCleared
rickhanlonii Apr 5, 2024
6353a54
Switch error after test to assetConsole methods
rickhanlonii Apr 5, 2024
ccb6115
Move assertConsoleLogsCleared for parity
rickhanlonii Apr 10, 2024
9822c22
Support local withoutStack options
rickhanlonii Apr 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 24 additions & 1 deletion packages/internal-test-utils/ReactInternalTestUtils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,14 @@ import {diff} from 'jest-diff';
import {equals} from '@jest/expect-utils';
import enqueueTask from './enqueueTask';
import simulateBrowserEventDispatch from './simulateBrowserEventDispatch';

import {
clearLogs,
clearWarnings,
clearErrors,
createLogAssertion,
} from './consoleMock';
export {act} from './internalAct';
const {assertConsoleLogsCleared} = require('internal-test-utils/consoleMock');

import {thrownErrors, actingUpdatesScopeDepth} from './internalAct';

Expand All @@ -24,6 +30,7 @@ function assertYieldsWereCleared(caller) {
Error.captureStackTrace(error, caller);
throw error;
}
assertConsoleLogsCleared();
}

export async function waitForMicrotasks() {
Expand Down Expand Up @@ -317,6 +324,22 @@ ${diff(expectedLog, actualLog)}
throw error;
}

export const assertConsoleLogDev = createLogAssertion(
'log',
'assertConsoleLogDev',
clearLogs,
);
export const assertConsoleWarnDev = createLogAssertion(
'warn',
'assertConsoleWarnDev',
clearWarnings,
);
export const assertConsoleErrorDev = createLogAssertion(
'error',
'assertConsoleErrorDev',
clearErrors,
);

// Simulates dispatching events, waiting for microtasks in between.
// This matches the browser behavior, which will flush microtasks
// between each event handler. This will allow discrete events to
Expand Down
Loading