Skip to content

NOT FOR MERGE run tests #29950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 10 commits into from
Closed

NOT FOR MERGE run tests #29950

wants to merge 10 commits into from

Conversation

eps1lon
Copy link
Collaborator

@eps1lon eps1lon commented Jun 19, 2024

No description provided.

@sebmarkbage
Encode the environmentName that thrown errors came from
fefc30b 
This is attached to our custom Error "sub class" on the receiving side
which also includes digest.

DEV-only.
@sebmarkbage
Generalize ReactFlightClientConsoleConfig to Fiber Clients too
57d3196
@sebmarkbage
Log error/warn to our consoleWithStackDev
233bafd 
This way this helper can use component stacks when available.
@sebmarkbage
Add Environment Badge in defaultOnCaughtError Logging
a66d878 
That way your typical log of an error that originated on the Server gets
a `[Server]` badge.

Unfortunately because defaultOnUncaughtError and defaultOnRecoverableError
doesn't use custom logging but goes through reportError. There's no place
for us to add this kind of formatted badging to the logs.

It's also unfortunate that you'd have to replicate this in user space.
@sebmarkbage
Same thing in Fizz
d1a3f38
@sebmarkbage
Ignore error
31ded8f
@sebmarkbage
Allow arg mismatches
5d99fac
@sebmarkbage
Align shouldIgnoreConsole opt-out
4bcac7e
@sebmarkbage
Fix env name
a3d6ef2
@vercel Vercel
Copy link

vercel bot commented Jun 19, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 19, 2024 4:11pm

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Jun 19, 2024
@react-sizebot
Copy link

react-sizebot commented Jun 19, 2024 •
edited
Loading

Comparing: 55c9d45...218f424

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.66 kB 6.66 kB = 1.82 kB 1.82 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 497.80 kB 497.80 kB = 89.24 kB 89.24 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.67 kB 6.67 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 502.62 kB 502.62 kB = 89.94 kB 89.94 kB
facebook-www/ReactDOM-prod.classic.js = 597.56 kB 597.56 kB = 105.38 kB 105.38 kB
facebook-www/ReactDOM-prod.modern.js = 571.49 kB 571.49 kB = 101.27 kB 101.27 kB
test_utils/ReactAllWarnings.js Deleted 63.88 kB 0.00 kB Deleted 15.96 kB 0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable-rc/react-server-dom-esm/cjs/react-server-dom-esm-client.browser.development.js +0.95% 69.40 kB 70.06 kB +0.84% 12.91 kB 13.02 kB
oss-stable-semver/react-server-dom-esm/cjs/react-server-dom-esm-client.browser.development.js +0.95% 69.40 kB 70.06 kB +0.84% 12.91 kB 13.02 kB
oss-stable/react-server-dom-esm/cjs/react-server-dom-esm-client.browser.development.js +0.95% 69.40 kB 70.06 kB +0.84% 12.91 kB 13.02 kB
oss-stable-rc/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.browser.development.js +0.93% 71.24 kB 71.90 kB +0.80% 13.31 kB 13.41 kB
oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.browser.development.js +0.93% 71.24 kB 71.90 kB +0.80% 13.31 kB 13.41 kB
oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.browser.development.js +0.93% 71.24 kB 71.90 kB +0.80% 13.31 kB 13.41 kB
oss-stable-rc/react-server-dom-webpack/cjs/react-server-dom-webpack-client.browser.development.js +0.92% 71.70 kB 72.36 kB +0.92% 13.41 kB 13.54 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-client.browser.development.js +0.92% 71.70 kB 72.36 kB +0.92% 13.41 kB 13.54 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-client.browser.development.js +0.92% 71.70 kB 72.36 kB +0.92% 13.41 kB 13.54 kB
oss-stable-rc/react-server-dom-esm/cjs/react-server-dom-esm-client.node.development.js +0.89% 74.34 kB 75.00 kB +0.84% 13.99 kB 14.11 kB
oss-stable-semver/react-server-dom-esm/cjs/react-server-dom-esm-client.node.development.js +0.89% 74.34 kB 75.00 kB +0.84% 13.99 kB 14.11 kB
oss-stable/react-server-dom-esm/cjs/react-server-dom-esm-client.node.development.js +0.89% 74.34 kB 75.00 kB +0.84% 13.99 kB 14.11 kB
oss-experimental/react-server-dom-esm/cjs/react-server-dom-esm-client.browser.development.js +0.89% 75.47 kB 76.13 kB +0.71% 14.42 kB 14.52 kB
oss-stable-rc/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.unbundled.development.js +0.87% 75.74 kB 76.40 kB +0.87% 14.30 kB 14.43 kB
oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.unbundled.development.js +0.87% 75.74 kB 76.40 kB +0.87% 14.30 kB 14.43 kB
oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.unbundled.development.js +0.87% 75.74 kB 76.40 kB +0.87% 14.30 kB 14.43 kB
oss-stable-rc/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.unbundled.development.js +0.87% 75.75 kB 76.41 kB +0.85% 14.31 kB 14.43 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.unbundled.development.js +0.87% 75.75 kB 76.41 kB +0.85% 14.31 kB 14.43 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.unbundled.development.js +0.87% 75.75 kB 76.41 kB +0.85% 14.31 kB 14.43 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.browser.development.js +0.86% 77.31 kB 77.98 kB +0.76% 14.81 kB 14.92 kB
oss-stable-rc/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.development.js +0.86% 76.53 kB 77.19 kB +0.92% 14.49 kB 14.62 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.development.js +0.86% 76.53 kB 77.19 kB +0.92% 14.49 kB 14.62 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.development.js +0.86% 76.53 kB 77.19 kB +0.92% 14.49 kB 14.62 kB
oss-stable-rc/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.development.js +0.86% 76.55 kB 77.21 kB +0.94% 14.47 kB 14.60 kB
oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.development.js +0.86% 76.55 kB 77.21 kB +0.94% 14.47 kB 14.60 kB
oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.development.js +0.86% 76.55 kB 77.21 kB +0.94% 14.47 kB 14.60 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.browser.development.js +0.86% 77.76 kB 78.43 kB +0.80% 14.93 kB 15.05 kB
oss-stable-rc/react-server-dom-webpack/cjs/react-server-dom-webpack-client.edge.development.js +0.85% 77.91 kB 78.57 kB +0.90% 14.71 kB 14.84 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-client.edge.development.js +0.85% 77.91 kB 78.57 kB +0.90% 14.71 kB 14.84 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-client.edge.development.js +0.85% 77.91 kB 78.57 kB +0.90% 14.71 kB 14.84 kB
oss-stable-rc/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.edge.development.js +0.85% 77.93 kB 78.59 kB +0.93% 14.68 kB 14.82 kB
oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.edge.development.js +0.85% 77.93 kB 78.59 kB +0.93% 14.68 kB 14.82 kB
oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.edge.development.js +0.85% 77.93 kB 78.59 kB +0.93% 14.68 kB 14.82 kB
oss-experimental/react-server-dom-esm/esm/react-server-dom-esm-client.browser.development.js +0.83% 108.69 kB 109.60 kB +0.87% 24.39 kB 24.60 kB
oss-experimental/react-server-dom-esm/cjs/react-server-dom-esm-client.node.development.js +0.83% 80.40 kB 81.07 kB +0.87% 15.40 kB 15.53 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.unbundled.development.js +0.82% 81.81 kB 82.48 kB +0.89% 15.72 kB 15.86 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.unbundled.development.js +0.82% 81.81 kB 82.48 kB +0.88% 15.73 kB 15.87 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.development.js +0.81% 82.60 kB 83.27 kB +0.90% 15.90 kB 16.04 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.development.js +0.81% 82.61 kB 83.28 kB +0.92% 15.88 kB 16.02 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.edge.development.js +0.80% 83.98 kB 84.65 kB +0.88% 16.17 kB 16.31 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.edge.development.js +0.80% 83.99 kB 84.66 kB +0.90% 16.14 kB 16.29 kB
oss-stable-rc/react-server-dom-esm/esm/react-server-dom-esm-client.browser.development.js +0.79% 99.38 kB 100.16 kB +0.76% 21.85 kB 22.01 kB
oss-stable-semver/react-server-dom-esm/esm/react-server-dom-esm-client.browser.development.js +0.79% 99.38 kB 100.16 kB +0.76% 21.85 kB 22.01 kB
oss-stable/react-server-dom-esm/esm/react-server-dom-esm-client.browser.development.js +0.79% 99.38 kB 100.16 kB +0.76% 21.85 kB 22.01 kB
oss-experimental/react-dom/cjs/react-dom-server.bun.production.js +0.51% 217.53 kB 218.65 kB +0.74% 39.66 kB 39.95 kB
oss-stable-rc/react-dom/cjs/react-dom-server.bun.production.js +0.50% 201.31 kB 202.31 kB +0.74% 37.51 kB 37.79 kB
oss-stable-semver/react-dom/cjs/react-dom-server.bun.production.js +0.50% 201.31 kB 202.31 kB +0.74% 37.51 kB 37.79 kB
oss-stable/react-dom/cjs/react-dom-server.bun.production.js +0.50% 201.37 kB 202.38 kB +0.74% 37.53 kB 37.81 kB
oss-stable-rc/react-dom/cjs/react-dom-server.node.production.js +0.50% 213.46 kB 214.52 kB +0.76% 39.31 kB 39.61 kB
oss-stable-semver/react-dom/cjs/react-dom-server.node.production.js +0.50% 213.46 kB 214.52 kB +0.76% 39.31 kB 39.61 kB
oss-stable/react-dom/cjs/react-dom-server.node.production.js +0.50% 213.52 kB 214.59 kB +0.76% 39.34 kB 39.64 kB
facebook-www/ReactDOMServerStreaming-prod.modern.js +0.49% 209.16 kB 210.20 kB +0.70% 38.94 kB 39.21 kB
oss-experimental/react-dom/cjs/react-dom-server.node.production.js +0.49% 238.63 kB 239.81 kB +0.75% 42.86 kB 43.18 kB
oss-stable-rc/react-dom/cjs/react-dom-server.edge.production.js +0.49% 217.53 kB 218.59 kB +0.74% 40.56 kB 40.86 kB
oss-stable-semver/react-dom/cjs/react-dom-server.edge.production.js +0.49% 217.53 kB 218.59 kB +0.74% 40.56 kB 40.86 kB
oss-stable/react-dom/cjs/react-dom-server.edge.production.js +0.49% 217.60 kB 218.66 kB +0.74% 40.58 kB 40.88 kB
oss-experimental/react-dom/cjs/react-dom-server.edge.production.js +0.48% 242.62 kB 243.79 kB +0.73% 43.62 kB 43.94 kB
oss-stable-rc/react-dom/cjs/react-dom-server.browser.production.js +0.47% 212.66 kB 213.66 kB +0.70% 38.73 kB 39.00 kB
oss-stable-semver/react-dom/cjs/react-dom-server.browser.production.js +0.47% 212.66 kB 213.66 kB +0.70% 38.73 kB 39.00 kB
oss-stable/react-dom/cjs/react-dom-server.browser.production.js +0.47% 212.73 kB 213.73 kB +0.70% 38.76 kB 39.03 kB
oss-experimental/react-dom/cjs/react-dom-server.browser.production.js +0.47% 237.20 kB 238.31 kB +0.72% 41.67 kB 41.97 kB
oss-experimental/react-noop-renderer/cjs/react-noop-renderer.production.js +0.33% 34.95 kB 35.07 kB +0.55% 6.55 kB 6.58 kB
oss-stable-rc/react-noop-renderer/cjs/react-noop-renderer.production.js +0.33% 34.95 kB 35.07 kB +0.55% 6.55 kB 6.58 kB
oss-stable-semver/react-noop-renderer/cjs/react-noop-renderer.production.js +0.33% 34.95 kB 35.07 kB +0.55% 6.55 kB 6.58 kB
oss-stable/react-noop-renderer/cjs/react-noop-renderer.production.js +0.33% 34.95 kB 35.07 kB +0.55% 6.55 kB 6.58 kB
oss-experimental/react-noop-renderer/cjs/react-noop-renderer-persistent.production.js +0.33% 35.08 kB 35.20 kB +0.55% 6.57 kB 6.60 kB
oss-stable-rc/react-noop-renderer/cjs/react-noop-renderer-persistent.production.js +0.33% 35.08 kB 35.20 kB +0.55% 6.57 kB 6.60 kB
oss-stable-semver/react-noop-renderer/cjs/react-noop-renderer-persistent.production.js +0.33% 35.08 kB 35.20 kB +0.55% 6.57 kB 6.60 kB
oss-stable/react-noop-renderer/cjs/react-noop-renderer-persistent.production.js +0.33% 35.08 kB 35.20 kB +0.55% 6.57 kB 6.60 kB
oss-experimental/react-dom/cjs/react-dom-server-legacy.browser.production.js +0.33% 211.98 kB 212.69 kB +0.55% 38.45 kB 38.67 kB
oss-experimental/react-dom/cjs/react-dom-server-legacy.node.production.js +0.32% 216.98 kB 217.68 kB +0.53% 40.31 kB 40.53 kB
oss-stable-rc/react-dom/cjs/react-dom-server.bun.development.js +0.32% 300.37 kB 301.34 kB +0.40% 59.10 kB 59.34 kB
oss-stable-semver/react-dom/cjs/react-dom-server.bun.development.js +0.32% 300.37 kB 301.34 kB +0.40% 59.10 kB 59.34 kB
oss-stable/react-dom/cjs/react-dom-server.bun.development.js +0.32% 300.44 kB 301.41 kB +0.40% 59.13 kB 59.36 kB
oss-stable-rc/react-noop-renderer/cjs/react-noop-renderer.development.js +0.31% 39.51 kB 39.64 kB +0.48% 7.30 kB 7.33 kB
oss-stable-semver/react-noop-renderer/cjs/react-noop-renderer.development.js +0.31% 39.51 kB 39.64 kB +0.48% 7.30 kB 7.33 kB
oss-stable/react-noop-renderer/cjs/react-noop-renderer.development.js +0.31% 39.51 kB 39.64 kB +0.48% 7.30 kB 7.33 kB
oss-experimental/react-noop-renderer/cjs/react-noop-renderer.development.js +0.31% 39.59 kB 39.72 kB +0.48% 7.32 kB 7.36 kB
oss-stable-rc/react-noop-renderer/cjs/react-noop-renderer-persistent.development.js +0.31% 39.65 kB 39.78 kB +0.48% 7.32 kB 7.35 kB
oss-stable-semver/react-noop-renderer/cjs/react-noop-renderer-persistent.development.js +0.31% 39.65 kB 39.78 kB +0.48% 7.32 kB 7.35 kB
oss-stable/react-noop-renderer/cjs/react-noop-renderer-persistent.development.js +0.31% 39.65 kB 39.78 kB +0.48% 7.32 kB 7.35 kB
oss-experimental/react-noop-renderer/cjs/react-noop-renderer-persistent.development.js +0.31% 39.73 kB 39.86 kB +0.48% 7.34 kB 7.38 kB
oss-experimental/react-dom/cjs/react-dom-server.bun.development.js +0.30% 319.86 kB 320.83 kB +0.38% 61.73 kB 61.97 kB
oss-stable-rc/react-dom/cjs/react-dom-server-legacy.browser.production.js +0.30% 197.43 kB 198.02 kB +0.47% 36.46 kB 36.63 kB
oss-stable-semver/react-dom/cjs/react-dom-server-legacy.browser.production.js +0.30% 197.43 kB 198.02 kB +0.47% 36.46 kB 36.63 kB
oss-stable/react-dom/cjs/react-dom-server-legacy.browser.production.js +0.30% 197.45 kB 198.05 kB +0.47% 36.48 kB 36.65 kB
oss-stable-rc/react-dom/cjs/react-dom-server.node.development.js +0.29% 345.65 kB 346.67 kB +0.38% 62.70 kB 62.94 kB
oss-stable-semver/react-dom/cjs/react-dom-server.node.development.js +0.29% 345.65 kB 346.67 kB +0.38% 62.70 kB 62.94 kB
oss-stable/react-dom/cjs/react-dom-server.node.development.js +0.29% 345.72 kB 346.74 kB +0.38% 62.73 kB 62.97 kB
oss-stable-rc/react-dom/cjs/react-dom-server-legacy.node.production.js +0.29% 201.87 kB 202.46 kB +0.47% 38.20 kB 38.38 kB
oss-stable-semver/react-dom/cjs/react-dom-server-legacy.node.production.js +0.29% 201.87 kB 202.46 kB +0.47% 38.20 kB 38.38 kB
oss-stable/react-dom/cjs/react-dom-server-legacy.node.production.js +0.29% 201.89 kB 202.49 kB +0.47% 38.22 kB 38.40 kB
oss-stable-rc/react-dom/cjs/react-dom-server.edge.development.js +0.29% 350.99 kB 352.01 kB +0.40% 64.06 kB 64.31 kB
oss-stable-semver/react-dom/cjs/react-dom-server.edge.development.js +0.29% 350.99 kB 352.01 kB +0.40% 64.06 kB 64.31 kB
oss-stable/react-dom/cjs/react-dom-server.edge.development.js +0.29% 351.06 kB 352.07 kB +0.40% 64.08 kB 64.34 kB
facebook-www/ReactDOMServer-prod.modern.js +0.29% 204.90 kB 205.50 kB +0.44% 37.51 kB 37.67 kB
facebook-www/ReactDOMServer-prod.classic.js +0.29% 205.56 kB 206.15 kB +0.45% 37.71 kB 37.88 kB
facebook-www/ReactDOMServerStreaming-dev.modern.js +0.28% 342.83 kB 343.80 kB +0.39% 62.36 kB 62.60 kB
oss-stable-rc/react-dom/cjs/react-dom-server.browser.development.js +0.28% 350.49 kB 351.46 kB +0.38% 63.98 kB 64.22 kB
oss-stable-semver/react-dom/cjs/react-dom-server.browser.development.js +0.28% 350.49 kB 351.46 kB +0.38% 63.98 kB 64.22 kB
oss-stable/react-dom/cjs/react-dom-server.browser.development.js +0.28% 350.56 kB 351.53 kB +0.38% 64.01 kB 64.25 kB
oss-experimental/react-dom/cjs/react-dom-server.node.development.js +0.27% 377.52 kB 378.54 kB +0.36% 66.97 kB 67.21 kB
oss-experimental/react-dom/cjs/react-dom-server.edge.development.js +0.27% 382.52 kB 383.54 kB +0.36% 67.54 kB 67.78 kB
oss-experimental/react-dom/cjs/react-dom-server.browser.development.js +0.25% 382.03 kB 382.99 kB +0.34% 67.47 kB 67.70 kB
oss-stable-rc/react-server/cjs/react-server.production.js +0.20% 106.03 kB 106.25 kB +0.33% 19.41 kB 19.48 kB
oss-stable-semver/react-server/cjs/react-server.production.js +0.20% 106.03 kB 106.25 kB +0.33% 19.41 kB 19.48 kB
oss-stable/react-server/cjs/react-server.production.js +0.20% 106.03 kB 106.25 kB +0.33% 19.41 kB 19.48 kB
test_utils/ReactAllWarnings.js Deleted 63.88 kB 0.00 kB Deleted 15.96 kB 0.00 kB

Generated by 🚫 dangerJS against 218f424

@eps1lon eps1lon force-pushed the errorenv-ignore-consoel branch from 9ba1534 to 415e355 Compare June 19, 2024 15:49
@eps1lon eps1lon force-pushed the errorenv-ignore-consoel branch from 415e355 to d2926eb Compare June 19, 2024 15:54
@eps1lon eps1lon force-pushed the errorenv-ignore-consoel branch from 13232fa to 218f424 Compare June 19, 2024 16:09
@eps1lon
Copy link
Collaborator Author

eps1lon commented Jun 19, 2024 •
edited
Loading

Just opened to show it passes CI. Replacing with a PR targetting the actual PR instead: sebmarkbage#6

@eps1lon eps1lon closed this Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@eps1lon @react-sizebot @facebook-github-bot @sebmarkbage