Skip to content

Turn on enableSiblingPrerendering in canary #31541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 14, 2024
Merged

Turn on enableSiblingPrerendering in canary #31541

merged 1 commit into from
Nov 14, 2024

Conversation

acdlite
Copy link
Collaborator

@acdlite acdlite commented Nov 14, 2024

In preparation for the next RC, I set this feature flag to true everywhere. I did not delete the feature flag yet, in case there are yet more bugs to be discovered.

I also didn't remove the dynamic feature flag from the Meta builds; I'll let the Meta folks handle that.

@acdlite
Turn on enableSiblingPrerendering in canary
372aa0a 
In preparation for the next RC, I set this feature flag to true
everywhere. I did not delete the feature flag yet, in case there are
yet more bugs to be discovered.

I also didn't remove the dynamic feature flag from the Meta builds; I'll
let the Meta folks handle that.
@vercel Vercel
Copy link

vercel bot commented Nov 14, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 14, 2024 4:11pm

@facebook-github-bot facebook-github-bot added the React Core Team Opened by a member of the React Core Team label Nov 14, 2024
@react-sizebot
Copy link

Comparing: 380f5d6...f394f3a

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB = 1.83 kB 1.82 kB
oss-stable/react-dom/cjs/react-dom-client.production.js +0.47% 506.73 kB 509.09 kB +0.44% 90.61 kB 91.00 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js +0.46% 511.67 kB 514.03 kB +0.43% 91.31 kB 91.71 kB
facebook-www/ReactDOM-prod.classic.js = 588.71 kB 588.71 kB = 104.18 kB 104.18 kB
facebook-www/ReactDOM-prod.modern.js = 578.98 kB 578.98 kB = 102.59 kB 102.59 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable-rc/react-art/cjs/react-art.production.js +0.69% 296.48 kB 298.53 kB +0.70% 50.96 kB 51.32 kB
oss-stable-semver/react-art/cjs/react-art.production.js +0.69% 296.48 kB 298.53 kB +0.70% 50.96 kB 51.32 kB
oss-stable/react-art/cjs/react-art.production.js +0.69% 296.55 kB 298.59 kB +0.70% 50.98 kB 51.34 kB
oss-stable-rc/react-reconciler/cjs/react-reconciler.production.js +0.68% 382.80 kB 385.41 kB +0.71% 62.64 kB 63.09 kB
oss-stable-semver/react-reconciler/cjs/react-reconciler.production.js +0.68% 382.80 kB 385.41 kB +0.71% 62.64 kB 63.09 kB
oss-stable/react-reconciler/cjs/react-reconciler.production.js +0.68% 382.82 kB 385.43 kB +0.71% 62.66 kB 63.11 kB
oss-experimental/react-art/cjs/react-art.production.js +0.68% 301.06 kB 303.11 kB +0.69% 51.74 kB 52.09 kB
oss-experimental/react-reconciler/cjs/react-reconciler.production.js +0.68% 387.88 kB 390.52 kB +0.66% 63.51 kB 63.93 kB
oss-stable-rc/react-test-renderer/cjs/react-test-renderer.production.js +0.67% 306.29 kB 308.33 kB +0.64% 54.19 kB 54.54 kB
oss-stable-semver/react-test-renderer/cjs/react-test-renderer.production.js +0.67% 306.29 kB 308.33 kB +0.64% 54.19 kB 54.54 kB
oss-stable/react-test-renderer/cjs/react-test-renderer.production.js +0.67% 306.35 kB 308.40 kB +0.64% 54.21 kB 54.56 kB
oss-experimental/react-test-renderer/cjs/react-test-renderer.production.js +0.67% 306.53 kB 308.58 kB +0.64% 54.25 kB 54.60 kB
facebook-react-native/react-test-renderer/cjs/ReactTestRenderer-prod.js +0.65% 323.65 kB 325.76 kB +0.62% 56.99 kB 57.35 kB
oss-stable-rc/react-reconciler/cjs/react-reconciler.profiling.js +0.65% 409.07 kB 411.73 kB +0.66% 66.38 kB 66.82 kB
oss-stable-semver/react-reconciler/cjs/react-reconciler.profiling.js +0.65% 409.07 kB 411.73 kB +0.66% 66.38 kB 66.82 kB
oss-stable/react-reconciler/cjs/react-reconciler.profiling.js +0.65% 409.09 kB 411.75 kB +0.66% 66.40 kB 66.84 kB
facebook-react-native/react-test-renderer/cjs/ReactTestRenderer-profiling.js +0.63% 345.57 kB 347.73 kB +0.58% 60.05 kB 60.40 kB
oss-experimental/react-reconciler/cjs/react-reconciler.profiling.js +0.60% 421.37 kB 423.92 kB +0.65% 68.63 kB 69.07 kB
react-native/implementations/ReactFabric-prod.js +0.60% 352.10 kB 354.22 kB +0.57% 61.64 kB 62.00 kB
react-native/implementations/ReactNativeRenderer-prod.js +0.59% 360.51 kB 362.63 kB +0.56% 63.03 kB 63.38 kB
react-native/implementations/ReactFabric-profiling.js +0.57% 377.46 kB 379.62 kB +0.50% 65.28 kB 65.61 kB
react-native/implementations/ReactNativeRenderer-profiling.js +0.56% 385.87 kB 388.02 kB +0.48% 66.87 kB 67.19 kB
oss-stable-rc/react-dom/cjs/react-dom-client.production.js +0.47% 506.63 kB 508.99 kB +0.44% 90.59 kB 90.98 kB
oss-stable-semver/react-dom/cjs/react-dom-client.production.js +0.47% 506.63 kB 508.99 kB +0.44% 90.59 kB 90.98 kB
oss-stable/react-dom/cjs/react-dom-client.production.js +0.47% 506.73 kB 509.09 kB +0.44% 90.61 kB 91.00 kB
oss-stable-rc/react-reconciler/cjs/react-reconciler.development.js +0.46% 634.18 kB 637.13 kB +0.46% 101.84 kB 102.31 kB
oss-stable-semver/react-reconciler/cjs/react-reconciler.development.js +0.46% 634.18 kB 637.13 kB +0.46% 101.84 kB 102.31 kB
oss-stable/react-reconciler/cjs/react-reconciler.development.js +0.46% 634.20 kB 637.15 kB +0.47% 101.86 kB 102.33 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js +0.46% 511.67 kB 514.03 kB +0.43% 91.31 kB 91.71 kB
oss-experimental/react-dom/cjs/react-dom-unstable_testing.production.js +0.45% 526.40 kB 528.76 kB +0.43% 94.96 kB 95.36 kB
oss-stable-rc/react-art/cjs/react-art.development.js +0.45% 551.27 kB 553.74 kB +0.43% 89.25 kB 89.64 kB
oss-stable-semver/react-art/cjs/react-art.development.js +0.45% 551.27 kB 553.74 kB +0.43% 89.25 kB 89.64 kB
oss-stable/react-art/cjs/react-art.development.js +0.45% 551.33 kB 553.80 kB +0.43% 89.28 kB 89.66 kB
oss-stable-rc/react-dom/cjs/react-dom-profiling.profiling.js +0.44% 537.16 kB 539.52 kB +0.45% 95.35 kB 95.78 kB
oss-stable-semver/react-dom/cjs/react-dom-profiling.profiling.js +0.44% 537.16 kB 539.52 kB +0.45% 95.35 kB 95.78 kB
oss-stable/react-dom/cjs/react-dom-profiling.profiling.js +0.44% 537.26 kB 539.63 kB +0.45% 95.37 kB 95.81 kB
oss-stable-rc/react-test-renderer/cjs/react-test-renderer.development.js +0.44% 547.45 kB 549.84 kB +0.44% 89.54 kB 89.94 kB
oss-stable-semver/react-test-renderer/cjs/react-test-renderer.development.js +0.44% 547.45 kB 549.84 kB +0.44% 89.54 kB 89.94 kB
oss-experimental/react-test-renderer/cjs/react-test-renderer.development.js +0.44% 547.48 kB 549.86 kB +0.44% 89.55 kB 89.95 kB
oss-stable/react-test-renderer/cjs/react-test-renderer.development.js +0.44% 547.51 kB 549.90 kB +0.44% 89.56 kB 89.96 kB
oss-experimental/react-reconciler/cjs/react-reconciler.development.js +0.43% 650.69 kB 653.47 kB +0.41% 104.46 kB 104.89 kB
facebook-www/ReactTestRenderer-dev.modern.js +0.42% 571.83 kB 574.22 kB +0.45% 93.59 kB 94.02 kB
facebook-www/ReactTestRenderer-dev.classic.js +0.42% 571.83 kB 574.22 kB +0.45% 93.59 kB 94.02 kB
oss-experimental/react-dom/cjs/react-dom-profiling.profiling.js +0.41% 549.34 kB 551.61 kB +0.42% 97.61 kB 98.02 kB
facebook-react-native/react-test-renderer/cjs/ReactTestRenderer-dev.js +0.41% 580.43 kB 582.82 kB +0.42% 94.56 kB 94.96 kB
oss-experimental/react-art/cjs/react-art.development.js +0.41% 568.99 kB 571.33 kB +0.39% 92.04 kB 92.40 kB
react-native/implementations/ReactFabric-dev.js +0.40% 632.92 kB 635.47 kB +0.36% 103.63 kB 104.01 kB
react-native/implementations/ReactNativeRenderer-dev.js +0.38% 642.66 kB 645.10 kB +0.35% 105.31 kB 105.68 kB
oss-stable-rc/react-dom/cjs/react-dom-client.development.js +0.30% 936.42 kB 939.28 kB +0.29% 158.47 kB 158.93 kB
oss-stable-semver/react-dom/cjs/react-dom-client.development.js +0.30% 936.42 kB 939.28 kB +0.29% 158.47 kB 158.93 kB
oss-stable/react-dom/cjs/react-dom-client.development.js +0.30% 936.53 kB 939.38 kB +0.29% 158.49 kB 158.96 kB
oss-stable-rc/react-dom/cjs/react-dom-profiling.development.js +0.30% 952.86 kB 955.72 kB +0.28% 161.30 kB 161.76 kB
oss-stable-semver/react-dom/cjs/react-dom-profiling.development.js +0.30% 952.86 kB 955.72 kB +0.28% 161.30 kB 161.76 kB
oss-stable/react-dom/cjs/react-dom-profiling.development.js +0.30% 952.97 kB 955.82 kB +0.28% 161.33 kB 161.78 kB
oss-experimental/react-dom/cjs/react-dom-client.development.js +0.28% 953.78 kB 956.46 kB +0.26% 161.32 kB 161.73 kB
oss-experimental/react-dom/cjs/react-dom-profiling.development.js +0.28% 970.22 kB 972.90 kB +0.25% 164.15 kB 164.56 kB
oss-experimental/react-dom/cjs/react-dom-unstable_testing.development.js +0.28% 970.72 kB 973.40 kB +0.25% 165.10 kB 165.51 kB

Generated by 🚫 dangerJS against 372aa0a

@poteto poteto requested a review from jackpope November 14, 2024 16:45
@acdlite acdlite merged commit 988e217 into facebook:main Nov 14, 2024
184 checks passed
github-actions bot pushed a commit that referenced this pull request Nov 14, 2024
@acdlite
Turn on enableSiblingPrerendering in canary (#31541)
5834fcd 
In preparation for the next RC, I set this feature flag to true
everywhere. I did not delete the feature flag yet, in case there are yet
more bugs to be discovered.

I also didn't remove the dynamic feature flag from the Meta builds; I'll
let the Meta folks handle that.

DiffTrain build for [988e217](988e217)
github-actions bot pushed a commit that referenced this pull request Nov 14, 2024
@acdlite
Turn on enableSiblingPrerendering in canary (#31541)
e7777dc 
In preparation for the next RC, I set this feature flag to true
everywhere. I did not delete the feature flag yet, in case there are yet
more bugs to be discovered.

I also didn't remove the dynamic feature flag from the Meta builds; I'll
let the Meta folks handle that.

DiffTrain build for [988e217](988e217)
This was referenced Nov 14, 2024
Merged
Closed
@eps1lon eps1lon mentioned this pull request Nov 22, 2024
Merged
@nickserv nickserv mentioned this pull request Feb 2, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@poteto poteto poteto approved these changes

@jackpope jackpope Awaiting requested review from jackpope

Assignees
No one assigned
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@acdlite @react-sizebot @poteto @facebook-github-bot