Update runtime workflow to use HEAD commit #31850
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
CLA Signed
React Core Team
This updates the CI workflow for the runtime build and tests to use the HEAD commit of the PR branch rather than the Fake News merge commit that the actions/checkout workflow baffingly defaults to. Testing against the merge commit never made sense to me as a behavior because as soon as someone updates upstream, it's out of date anyway. It should just match the exact commit that the developer pushed, and the once that appears in the GitHub UI.
acdlite
force-pushed
the
update-ci-to-use-head-commit
branch
from
0441d85 to
2427883
Compare
|
Comparing: 7de040c...2795d63 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: Expand to show
|
poteto
approved these changes
Dec 19, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Dec 19, 2024
This updates the CI workflow for the runtime build and tests to use the HEAD commit of the PR branch rather than the Fake News merge commit that the `@actions/checkout` action bafflingly defaults to. Testing against the merge commit never made sense to me as a behavior because as soon as someone updates upstream, it's out of date anyway. It should just match the exact commit that the developer pushed, and the once that appears in the GitHub UI. DiffTrain build for [9463d51](9463d51)
This was referenced Dec 19, 2024
acdlite
added a commit
to acdlite/react
that referenced
this pull request
Mar 17, 2025
Follow-up to facebook#31850. We want to build using the original commit SHA, not the merge commit that GitHub Actions creates behind the scenes. We were already checking out the correct commit object, but the COMMIT_SHA artifact was still pointing to the merge commit. This fix the sizebot links to point to working URLs, too.
acdlite
added a commit
that referenced
this pull request
Mar 17, 2025
Follow-up to #31850. We want to build using the original commit SHA, not the merge commit that GitHub Actions creates behind the scenes. We were already checking out the correct commit object, but the COMMIT_SHA artifact was still pointing to the merge commit. This should fix the sizebot links to point to working URLs, too.
github-actions bot
pushed a commit
that referenced
this pull request
Mar 17, 2025
Follow-up to #31850. We want to build using the original commit SHA, not the merge commit that GitHub Actions creates behind the scenes. We were already checking out the correct commit object, but the COMMIT_SHA artifact was still pointing to the merge commit. This should fix the sizebot links to point to working URLs, too. DiffTrain build for [9320a01](9320a01)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the CI workflow for the runtime build and tests to use the HEAD commit of the PR branch rather than the Fake News merge commit that the
@actions/checkoutaction bafflingly defaults to.Testing against the merge commit never made sense to me as a behavior because as soon as someone updates upstream, it's out of date anyway.
It should just match the exact commit that the developer pushed, and the once that appears in the GitHub UI.