Skip to content

[ci] getWorkflowRun should not throw early if workflow hasn't completed #31861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 19, 2024
Merged

[ci] getWorkflowRun should not throw early if workflow hasn't completed #31861

merged 1 commit into from
Dec 19, 2024
+1 −6

Conversation

poteto
Copy link
Member

@poteto poteto commented Dec 19, 2024

We already have handling and retry logic for in-flight workflows in downloadArtifactsFromGitHub, so there's no need to exit early if we find a workflow for a given commit but it hasn't finished yet.

@vercel Vercel
Copy link

vercel bot commented Dec 19, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 19, 2024 6:00pm

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Dec 19, 2024
@poteto
[ci] getWorkflowRun should not throw early if workflow hasn't completed
9c70ff5 
We already have handling and retry logic for in-flight workflows in `downloadArtifactsFromGitHub`, so there's no need to exit early if we find a workflow for a given commit but it hasn't finished yet.
@poteto poteto changed the title [ci] getWorkflowRun shoud not throw early if workflow hasn't completed [ci] getWorkflowRun should not throw early if workflow hasn't completed Dec 19, 2024
rickhanlonii
rickhanlonii approved these changes Dec 19, 2024
View reviewed changes
Copy link
Member

@rickhanlonii rickhanlonii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@react-sizebot
Copy link

Comparing: 9f540fc...14ffedf

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB = 1.83 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 511.38 kB 511.38 kB = 91.38 kB 91.38 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB +0.05% 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 517.53 kB 517.53 kB = 92.34 kB 92.34 kB
facebook-www/ReactDOM-prod.classic.js = 593.09 kB 593.09 kB = 104.45 kB 104.45 kB
facebook-www/ReactDOM-prod.modern.js = 583.35 kB 583.35 kB = 102.90 kB 102.90 kB
oss-experimental/react-server-dom-parcel/server.edge.js = 0.77 kB 0.70 kB = 0.30 kB 0.29 kB
oss-stable-semver/react-server-dom-parcel/server.edge.js = 0.77 kB 0.70 kB = 0.30 kB 0.29 kB
oss-stable/react-server-dom-parcel/server.edge.js = 0.77 kB 0.70 kB = 0.30 kB 0.29 kB
oss-experimental/react-server-dom-turbopack/server.edge.js = 0.74 kB 0.67 kB = 0.30 kB 0.29 kB
oss-stable-semver/react-server-dom-turbopack/server.edge.js = 0.74 kB 0.67 kB = 0.30 kB 0.29 kB
oss-stable/react-server-dom-turbopack/server.edge.js = 0.74 kB 0.67 kB = 0.30 kB 0.29 kB
oss-experimental/react-server-dom-webpack/server.edge.js = 0.73 kB 0.66 kB = 0.30 kB 0.29 kB
oss-stable-semver/react-server-dom-webpack/server.edge.js = 0.73 kB 0.66 kB = 0.30 kB 0.29 kB
oss-stable/react-server-dom-webpack/server.edge.js = 0.73 kB 0.66 kB = 0.30 kB 0.29 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.edge.development.js = 156.32 kB 154.98 kB = 28.77 kB 28.50 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.edge.development.js = 156.25 kB 154.91 kB = 28.76 kB 28.49 kB
oss-experimental/react-server-dom-parcel/cjs/react-server-dom-parcel-server.edge.development.js = 148.06 kB 146.75 kB = 27.33 kB 27.08 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.edge.development.js = 141.81 kB 140.46 kB = 26.33 kB 26.07 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.edge.development.js = 141.81 kB 140.46 kB = 26.33 kB 26.07 kB
oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.edge.development.js = 141.74 kB 140.39 kB = 26.31 kB 26.06 kB
oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.edge.development.js = 141.74 kB 140.39 kB = 26.31 kB 26.06 kB
oss-stable-semver/react-server-dom-parcel/cjs/react-server-dom-parcel-server.edge.development.js = 133.55 kB 132.24 kB = 24.91 kB 24.65 kB
oss-stable/react-server-dom-parcel/cjs/react-server-dom-parcel-server.edge.development.js = 133.55 kB 132.24 kB = 24.91 kB 24.65 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.edge.production.js = 99.19 kB 98.09 kB = 20.25 kB 20.01 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.edge.production.js = 99.13 kB 98.03 kB = 20.24 kB 20.00 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.edge.production.js = 94.73 kB 93.64 kB = 19.46 kB 19.24 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.edge.production.js = 94.73 kB 93.64 kB = 19.46 kB 19.24 kB
oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.edge.production.js = 94.67 kB 93.57 kB = 19.45 kB 19.22 kB
oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.edge.production.js = 94.67 kB 93.57 kB = 19.45 kB 19.22 kB
oss-experimental/react-server-dom-parcel/cjs/react-server-dom-parcel-server.edge.production.js = 91.85 kB 90.76 kB = 18.98 kB 18.76 kB
oss-stable-semver/react-server-dom-parcel/cjs/react-server-dom-parcel-server.edge.production.js = 87.39 kB 86.31 kB = 18.28 kB 18.05 kB
oss-stable/react-server-dom-parcel/cjs/react-server-dom-parcel-server.edge.production.js = 87.39 kB 86.31 kB = 18.28 kB 18.05 kB
oss-experimental/react-server-dom-parcel/server.edge.js = 0.77 kB 0.70 kB = 0.30 kB 0.29 kB
oss-stable-semver/react-server-dom-parcel/server.edge.js = 0.77 kB 0.70 kB = 0.30 kB 0.29 kB
oss-stable/react-server-dom-parcel/server.edge.js = 0.77 kB 0.70 kB = 0.30 kB 0.29 kB
oss-experimental/react-server-dom-turbopack/server.edge.js = 0.74 kB 0.67 kB = 0.30 kB 0.29 kB
oss-stable-semver/react-server-dom-turbopack/server.edge.js = 0.74 kB 0.67 kB = 0.30 kB 0.29 kB
oss-stable/react-server-dom-turbopack/server.edge.js = 0.74 kB 0.67 kB = 0.30 kB 0.29 kB
oss-experimental/react-server-dom-webpack/server.edge.js = 0.73 kB 0.66 kB = 0.30 kB 0.29 kB
oss-stable-semver/react-server-dom-webpack/server.edge.js = 0.73 kB 0.66 kB = 0.30 kB 0.29 kB
oss-stable/react-server-dom-webpack/server.edge.js = 0.73 kB 0.66 kB = 0.30 kB 0.29 kB

Generated by 🚫 dangerJS against 9c70ff5

@poteto poteto merged commit c70ab3f into main Dec 19, 2024
187 checks passed
@poteto poteto deleted the pr31861 branch December 19, 2024 18:03
@vercel-release-bot vercel-release-bot mentioned this pull request Dec 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rickhanlonii rickhanlonii rickhanlonii approved these changes

Assignees
No one assigned
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@poteto @react-sizebot @rickhanlonii @facebook-github-bot