Skip to content

Added dev-only warning for null/undefined create in use*Effect #32355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 11, 2025
+24 −0
Merged

Added dev-only warning for null/undefined create in use*Effect #32355

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7c6fc57
Added dev-only warning for null/undefined create in use*Effect
JoshuaKGoldberg Feb 11, 2025
45e4ca4
Apply suggestions from code review
JoshuaKGoldberg Feb 11, 2025
3d26657
refactor: inline the other create == null checks
JoshuaKGoldberg Feb 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions packages/react/src/ReactHooks.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,14 @@ export function useEffect(
updateDeps?: Array<mixed> | void | null,
destroy?: ((resource: {...} | void | null) => void) | void,
): void {
if (__DEV__) {
if (create == null) {
console.warn(
'React Hook useEffect requires an effect callback. Did you forget to pass a callback to the hook?',
);
}
}

const dispatcher = resolveDispatcher();
if (
enableUseEffectCRUDOverload &&
Expand All @@ -118,6 +126,14 @@ export function useInsertionEffect(
create: () => (() => void) | void,
deps: Array<mixed> | void | null,
): void {
if (__DEV__) {
if (create == null) {
console.warn(
'React Hook useInsertionEffect requires an effect callback. Did you forget to pass a callback to the hook?',
);
}
}

const dispatcher = resolveDispatcher();
return dispatcher.useInsertionEffect(create, deps);
}
Expand All @@ -126,6 +142,14 @@ export function useLayoutEffect(
create: () => (() => void) | void,
deps: Array<mixed> | void | null,
): void {
if (__DEV__) {
if (create == null) {
console.warn(
'React Hook useLayoutEffect requires an effect callback. Did you forget to pass a callback to the hook?',
);
}
}

const dispatcher = resolveDispatcher();
return dispatcher.useLayoutEffect(create, deps);
}
Expand Down
Loading