Skip to content

[devtools] add filters for internal builds #32646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 17, 2025
Merged

[devtools] add filters for internal builds #32646

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 11 additions & 6 deletions packages/react-devtools-shared/src/devtools/views/Settings/ComponentsSettings.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,8 @@ import {
ElementTypeOtherOrUnknown,
ElementTypeProfiler,
ElementTypeSuspense,
ElementTypeActivity,
ElementTypeViewTransition,
} from 'react-devtools-shared/src/frontend/types';
import {getDefaultOpenInEditorURL} from 'react-devtools-shared/src/utils';

Expand All @@ -56,6 +58,7 @@ import type {
RegExpComponentFilter,
EnvironmentNameComponentFilter,
} from 'react-devtools-shared/src/frontend/types';
import {isInternalFacebookBuild} from 'react-devtools-feature-flags';

const vscodeFilepath = 'vscode://file/{path}:{line}';

Expand Down Expand Up @@ -472,8 +475,9 @@ export default function ComponentsSettings({
((parseInt(currentTarget.value, 10): any): ElementType),
)
}>
{/* TODO: currently only experimental, only list this if it's available */}
{/*<option value={ElementTypeActivity}>activity</option>*/}
{isInternalFacebookBuild && (
<option value={ElementTypeActivity}>activity</option>
)}
<option value={ElementTypeClass}>class</option>
<option value={ElementTypeContext}>context</option>
<option value={ElementTypeFunction}>function</option>
Expand All @@ -487,10 +491,11 @@ export default function ComponentsSettings({
<option value={ElementTypeOtherOrUnknown}>other</option>
<option value={ElementTypeProfiler}>profiler</option>
<option value={ElementTypeSuspense}>suspense</option>
{/* TODO: currently only experimental, only list this if it's available */}
{/*<option value={ElementTypeViewTransition}>*/}
{/* view transition*/}
{/*</option>*/}
{isInternalFacebookBuild && (
<option value={ElementTypeViewTransition}>
view transition
</option>
)}
</select>
)}
{(componentFilter.type === ComponentFilterLocation ||
Expand Down
Loading