[compiler] Add types for WeakMap, WeakSet, and reanimated shared values #33077
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Building on @mofeiZ's recent work to type constructors. Also, types for reanimated values which are useful in the next PR. [ghstack-poisoned]
This was referenced May 1, 2025
…shared values" Building on mofeiz's recent work to type constructors. Also, types for reanimated values which are useful in the next PR. [ghstack-poisoned]
mofeiZ
reviewed
May 1, 2025
| addFunction(BUILTIN_SHAPES, [], { | ||
| positionalParams: [Effect.Capture], | ||
| restParam: null, | ||
| returnType: {kind: 'Object', shapeId: BuiltInSetId}, |
There was a problem hiding this comment.
nit: returns BuiltInWeakSetId
mofeiZ
reviewed
May 1, 2025
| addFunction(BUILTIN_SHAPES, [], { | ||
| positionalParams: [Effect.Capture, Effect.Capture], | ||
| restParam: null, | ||
| returnType: {kind: 'Object', shapeId: BuiltInMapId}, |
There was a problem hiding this comment.
nit: returns BuiltInWeakMapId
mofeiZ
approved these changes
May 1, 2025
…shared values" Building on mofeiz's recent work to type constructors. Also, types for reanimated values which are useful in the next PR. [ghstack-poisoned]
…shared values" Building on mofeiz's recent work to type constructors. Also, types for reanimated values which are useful in the next PR. [ghstack-poisoned]
|
good call, added fixtures |
This was referenced May 5, 2025
This was referenced May 12, 2025
This was referenced May 16, 2025
17 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Building on @mofeiZ's recent work to type constructors. Also, types for reanimated values which are useful in the next PR.