Skip to content

Conversation

sebmarkbage
Copy link
Collaborator

It turns out this was being compiled to a _defineProperty helper by Babel or Closure. We're supposed to have it error the build when we use features like this that might get compiled.

We should stick to simple ES5 features.

It turns out this was being compiled to a _defineProperty helper.
@github-actions github-actions bot added the React Core Team Opened by a member of the React Core Team label Jun 22, 2025
@react-sizebot
Copy link

Comparing: 6c7b1a1...010f1e2

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB = 1.83 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 530.57 kB 530.57 kB = 93.67 kB 93.67 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 651.66 kB 651.66 kB = 114.78 kB 114.78 kB
facebook-www/ReactDOM-prod.classic.js = 674.81 kB 674.81 kB = 118.78 kB 118.78 kB
facebook-www/ReactDOM-prod.modern.js = 665.30 kB 665.30 kB = 117.19 kB 117.19 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.unbundled.production.js = 62.16 kB 62.03 kB = 12.47 kB 12.45 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.unbundled.production.js = 62.16 kB 62.03 kB = 12.47 kB 12.45 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.production.js = 60.56 kB 60.44 kB = 12.31 kB 12.29 kB
oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.production.js = 60.02 kB 59.89 kB = 12.22 kB 12.20 kB
oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.production.js = 60.02 kB 59.89 kB = 12.22 kB 12.20 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.edge.production.js = 59.86 kB 59.73 kB = 12.22 kB 12.20 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.edge.production.js = 59.77 kB 59.65 kB = 12.19 kB 12.17 kB
oss-experimental/react-client/cjs/react-client-flight.production.js = 58.61 kB 58.49 kB = 10.90 kB 10.88 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-client.edge.production.js = 59.31 kB 59.19 kB = 12.13 kB 12.11 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-client.edge.production.js = 59.31 kB 59.19 kB = 12.13 kB 12.11 kB
oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.edge.production.js = 59.23 kB 59.10 kB = 12.11 kB 12.09 kB
oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.edge.production.js = 59.23 kB 59.10 kB = 12.11 kB 12.09 kB
oss-stable/react-client/cjs/react-client-flight.production.js = 58.16 kB 58.03 kB = 10.83 kB 10.81 kB
oss-stable-semver/react-client/cjs/react-client-flight.production.js = 58.13 kB 58.01 kB = 10.81 kB 10.79 kB
oss-experimental/react-server-dom-parcel/cjs/react-server-dom-parcel-client.node.production.js = 57.41 kB 57.28 kB = 11.69 kB 11.67 kB
oss-stable-semver/react-server-dom-parcel/cjs/react-server-dom-parcel-client.node.production.js = 56.86 kB 56.74 kB = 11.60 kB 11.58 kB
oss-stable/react-server-dom-parcel/cjs/react-server-dom-parcel-client.node.production.js = 56.86 kB 56.74 kB = 11.60 kB 11.58 kB
oss-experimental/react-server-dom-parcel/cjs/react-server-dom-parcel-client.edge.production.js = 56.74 kB 56.62 kB = 11.60 kB 11.58 kB
oss-stable-semver/react-server-dom-parcel/cjs/react-server-dom-parcel-client.edge.production.js = 56.20 kB 56.07 kB = 11.52 kB 11.50 kB
oss-stable/react-server-dom-parcel/cjs/react-server-dom-parcel-client.edge.production.js = 56.20 kB 56.07 kB = 11.52 kB 11.50 kB
oss-experimental/react-server-dom-esm/cjs/react-server-dom-esm-client.node.production.js = 55.95 kB 55.82 kB = 11.42 kB 11.39 kB
oss-stable-semver/react-server-dom-esm/cjs/react-server-dom-esm-client.node.production.js = 55.40 kB 55.28 kB = 11.33 kB 11.30 kB
oss-stable/react-server-dom-esm/cjs/react-server-dom-esm-client.node.production.js = 55.40 kB 55.28 kB = 11.33 kB 11.30 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.browser.production.js = 53.85 kB 53.73 kB = 10.98 kB 10.96 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.browser.production.js = 53.42 kB 53.29 kB = 10.88 kB 10.85 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-client.browser.production.js = 53.31 kB 53.18 kB = 10.89 kB 10.86 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-client.browser.production.js = 53.31 kB 53.18 kB = 10.89 kB 10.86 kB
oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.browser.production.js = 52.87 kB 52.75 kB = 10.79 kB 10.76 kB
oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.browser.production.js = 52.87 kB 52.75 kB = 10.79 kB 10.76 kB
oss-experimental/react-server-dom-esm/cjs/react-server-dom-esm-client.browser.production.js = 51.51 kB 51.38 kB = 10.48 kB 10.46 kB
oss-experimental/react-server-dom-parcel/cjs/react-server-dom-parcel-client.browser.production.js = 51.29 kB 51.17 kB = 10.38 kB 10.35 kB
oss-stable-semver/react-server-dom-esm/cjs/react-server-dom-esm-client.browser.production.js = 50.96 kB 50.84 kB = 10.39 kB 10.37 kB
oss-stable/react-server-dom-esm/cjs/react-server-dom-esm-client.browser.production.js = 50.96 kB 50.84 kB = 10.39 kB 10.37 kB
oss-stable-semver/react-server-dom-parcel/cjs/react-server-dom-parcel-client.browser.production.js = 50.75 kB 50.62 kB = 10.28 kB 10.26 kB
oss-stable/react-server-dom-parcel/cjs/react-server-dom-parcel-client.browser.production.js = 50.75 kB 50.62 kB = 10.28 kB 10.26 kB
oss-experimental/react-server-dom-esm/esm/react-server-dom-esm-client.browser.development.js = 154.30 kB 153.60 kB = 36.03 kB 35.75 kB
oss-stable/react-server-dom-esm/esm/react-server-dom-esm-client.browser.development.js = 137.11 kB 136.40 kB = 32.23 kB 31.95 kB
oss-stable-semver/react-server-dom-esm/esm/react-server-dom-esm-client.browser.development.js = 137.08 kB 136.38 kB = 32.20 kB 31.92 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.development.js = 129.89 kB 129.19 kB = 23.98 kB 23.77 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.unbundled.development.js = 128.56 kB 127.86 kB = 23.72 kB 23.52 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.development.js = 126.21 kB 125.51 kB = 23.48 kB 23.27 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.edge.development.js = 125.23 kB 124.53 kB = 23.39 kB 23.18 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.edge.development.js = 125.14 kB 124.44 kB = 23.35 kB 23.14 kB
oss-experimental/react-server-dom-parcel/cjs/react-server-dom-parcel-client.node.development.js = 123.28 kB 122.58 kB = 22.98 kB 22.78 kB
oss-experimental/react-server-dom-parcel/cjs/react-server-dom-parcel-client.edge.development.js = 122.04 kB 121.34 kB = 22.85 kB 22.65 kB
oss-experimental/react-server-dom-esm/cjs/react-server-dom-esm-client.node.development.js = 120.75 kB 120.05 kB = 22.50 kB 22.30 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.browser.development.js = 118.90 kB 118.20 kB = 22.25 kB 22.04 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.browser.development.js = 118.34 kB 117.64 kB = 22.11 kB 21.89 kB
oss-experimental/react-client/cjs/react-client-flight.development.js = 117.81 kB 117.10 kB = 21.48 kB 21.27 kB
oss-experimental/react-server-dom-parcel/cjs/react-server-dom-parcel-client.browser.development.js = 116.51 kB 115.81 kB = 21.64 kB 21.44 kB
oss-experimental/react-server-dom-esm/cjs/react-server-dom-esm-client.browser.development.js = 116.16 kB 115.46 kB = 21.72 kB 21.51 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.development.js = 112.41 kB 111.71 kB = 20.94 kB 20.72 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.development.js = 112.41 kB 111.71 kB = 20.94 kB 20.72 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.unbundled.development.js = 111.08 kB 110.37 kB = 20.68 kB 20.47 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.unbundled.development.js = 111.08 kB 110.37 kB = 20.68 kB 20.47 kB
oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.development.js = 108.72 kB 108.02 kB = 20.45 kB 20.24 kB
oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.development.js = 108.72 kB 108.02 kB = 20.45 kB 20.24 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-client.edge.development.js = 107.74 kB 107.04 kB = 20.31 kB 20.10 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-client.edge.development.js = 107.74 kB 107.04 kB = 20.31 kB 20.10 kB
oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.edge.development.js = 107.65 kB 106.95 kB = 20.28 kB 20.06 kB
oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.edge.development.js = 107.65 kB 106.95 kB = 20.28 kB 20.06 kB
oss-stable-semver/react-server-dom-parcel/cjs/react-server-dom-parcel-client.node.development.js = 105.80 kB 105.09 kB = 19.95 kB 19.75 kB
oss-stable/react-server-dom-parcel/cjs/react-server-dom-parcel-client.node.development.js = 105.80 kB 105.09 kB = 19.95 kB 19.75 kB
oss-stable-semver/react-server-dom-parcel/cjs/react-server-dom-parcel-client.edge.development.js = 104.56 kB 103.85 kB = 19.79 kB 19.59 kB
oss-stable/react-server-dom-parcel/cjs/react-server-dom-parcel-client.edge.development.js = 104.56 kB 103.85 kB = 19.79 kB 19.59 kB
oss-stable-semver/react-server-dom-esm/cjs/react-server-dom-esm-client.node.development.js = 103.27 kB 102.57 kB = 19.47 kB 19.28 kB
oss-stable/react-server-dom-esm/cjs/react-server-dom-esm-client.node.development.js = 103.27 kB 102.57 kB = 19.47 kB 19.28 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-client.browser.development.js = 101.40 kB 100.70 kB = 19.24 kB 19.02 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-client.browser.development.js = 101.35 kB 100.65 kB = 19.22 kB 19.00 kB
oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.browser.development.js = 100.84 kB 100.14 kB = 19.10 kB 18.89 kB
oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.browser.development.js = 100.79 kB 100.09 kB = 19.08 kB 18.87 kB
oss-stable/react-client/cjs/react-client-flight.development.js = 100.31 kB 99.61 kB = 18.46 kB 18.26 kB
oss-stable-semver/react-client/cjs/react-client-flight.development.js = 100.29 kB 99.59 kB = 18.44 kB 18.23 kB
oss-stable/react-server-dom-parcel/cjs/react-server-dom-parcel-client.browser.development.js = 99.02 kB 98.31 kB = 18.67 kB 18.47 kB
oss-stable-semver/react-server-dom-parcel/cjs/react-server-dom-parcel-client.browser.development.js = 98.97 kB 98.26 kB = 18.65 kB 18.45 kB
oss-stable/react-server-dom-esm/cjs/react-server-dom-esm-client.browser.development.js = 98.66 kB 97.96 kB = 18.71 kB 18.50 kB
oss-stable-semver/react-server-dom-esm/cjs/react-server-dom-esm-client.browser.development.js = 98.61 kB 97.91 kB = 18.69 kB 18.48 kB

Generated by 🚫 dangerJS against 010f1e2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants