Skip to content

flags: make enableAsyncDebugInfo dynamic for www #34430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 26, 2025
Merged

flags: make enableAsyncDebugInfo dynamic for www #34430

merged 1 commit into from
Sep 26, 2025
+4 −2

Conversation

hoxyq
Copy link
Contributor

@hoxyq hoxyq commented Sep 9, 2025

As titled. This adds dev-only debugging information to Fizz / Flight that could be used for tracking Promise's stack traces in "suspended by" section of DevTools.

@meta-cla meta-cla bot added the CLA Signed label Sep 9, 2025
@react-sizebot
Copy link

react-sizebot commented Sep 9, 2025 •
edited
Loading

Comparing: 8d557a6...6c082ec

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB = 1.83 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 534.43 kB 534.43 kB = 94.33 kB 94.33 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 663.69 kB 663.69 kB = 117.00 kB 117.00 kB
facebook-www/ReactDOM-prod.classic.js = 687.59 kB 687.59 kB = 121.04 kB 121.04 kB
facebook-www/ReactDOM-prod.modern.js = 678.02 kB 678.02 kB = 119.40 kB 119.40 kB
facebook-www/React-dev.modern.js +2.54% 52.78 kB 54.12 kB +2.08% 11.83 kB 12.07 kB
facebook-www/React-dev.classic.js +2.54% 52.78 kB 54.12 kB +2.08% 11.83 kB 12.07 kB
oss-stable-semver/react-server-dom-parcel/cjs/react-server-dom-parcel-server.edge.development.js = 186.03 kB 182.24 kB = 33.71 kB 32.99 kB
oss-stable/react-server-dom-parcel/cjs/react-server-dom-parcel-server.edge.development.js = 186.03 kB 182.24 kB = 33.71 kB 32.99 kB
oss-stable-semver/react-server-dom-parcel/cjs/react-server-dom-parcel-server.browser.development.js = 182.30 kB 178.51 kB = 33.22 kB 32.48 kB
oss-stable/react-server-dom-parcel/cjs/react-server-dom-parcel-server.browser.development.js = 182.30 kB 178.51 kB = 33.22 kB 32.48 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.production.js = 112.46 kB 109.27 kB = 22.45 kB 21.85 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.production.js = 112.44 kB 109.25 kB = 22.45 kB 21.84 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.unbundled.production.js = 111.39 kB 108.19 kB = 22.23 kB 21.62 kB
oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.production.js = 106.97 kB 103.77 kB = 21.53 kB 20.91 kB
oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.production.js = 106.97 kB 103.77 kB = 21.53 kB 20.91 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.production.js = 106.94 kB 103.75 kB = 21.52 kB 20.90 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.production.js = 106.94 kB 103.75 kB = 21.52 kB 20.90 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.edge.production.js = 106.17 kB 102.97 kB = 21.45 kB 20.84 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.edge.production.js = 106.17 kB 102.97 kB = 21.45 kB 20.85 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.unbundled.production.js = 105.89 kB 102.70 kB = 21.31 kB 20.69 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.unbundled.production.js = 105.89 kB 102.70 kB = 21.31 kB 20.69 kB
oss-experimental/react-server-dom-parcel/cjs/react-server-dom-parcel-server.node.production.js = 105.31 kB 102.12 kB = 21.20 kB 20.57 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.browser.production.js = 105.21 kB 102.02 kB = 21.23 kB 20.63 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.browser.production.js = 104.86 kB 101.67 kB = 21.13 kB 20.53 kB
oss-experimental/react-server-dom-esm/cjs/react-server-dom-esm-server.node.production.js = 101.39 kB 98.19 kB = 20.75 kB 20.14 kB
oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.edge.production.js = 100.55 kB 97.36 kB = 20.53 kB 19.92 kB
oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.edge.production.js = 100.55 kB 97.36 kB = 20.53 kB 19.92 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.edge.production.js = 100.55 kB 97.36 kB = 20.53 kB 19.92 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.edge.production.js = 100.55 kB 97.36 kB = 20.53 kB 19.92 kB
oss-stable-semver/react-server-dom-parcel/cjs/react-server-dom-parcel-server.node.production.js = 99.82 kB 96.62 kB = 20.33 kB 19.72 kB
oss-stable/react-server-dom-parcel/cjs/react-server-dom-parcel-server.node.production.js = 99.82 kB 96.62 kB = 20.33 kB 19.72 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.browser.production.js = 99.69 kB 96.49 kB = 20.33 kB 19.72 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.browser.production.js = 99.69 kB 96.49 kB = 20.33 kB 19.72 kB
oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.browser.production.js = 99.33 kB 96.14 kB = 20.24 kB 19.63 kB
oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.browser.production.js = 99.33 kB 96.14 kB = 20.24 kB 19.63 kB
oss-experimental/react-server-dom-parcel/cjs/react-server-dom-parcel-server.edge.production.js = 99.09 kB 95.89 kB = 20.23 kB 19.61 kB
oss-experimental/react-server-dom-parcel/cjs/react-server-dom-parcel-server.browser.production.js = 97.80 kB 94.61 kB = 19.94 kB 19.34 kB
oss-stable-semver/react-server-dom-esm/cjs/react-server-dom-esm-server.node.production.js = 95.89 kB 92.70 kB = 19.85 kB 19.25 kB
oss-stable/react-server-dom-esm/cjs/react-server-dom-esm-server.node.production.js = 95.89 kB 92.70 kB = 19.85 kB 19.25 kB
oss-stable-semver/react-server-dom-parcel/cjs/react-server-dom-parcel-server.edge.production.js = 93.47 kB 90.28 kB = 19.37 kB 18.75 kB
oss-stable/react-server-dom-parcel/cjs/react-server-dom-parcel-server.edge.production.js = 93.47 kB 90.28 kB = 19.37 kB 18.75 kB
oss-stable-semver/react-server-dom-parcel/cjs/react-server-dom-parcel-server.browser.production.js = 92.27 kB 89.08 kB = 19.10 kB 18.49 kB
oss-stable/react-server-dom-parcel/cjs/react-server-dom-parcel-server.browser.production.js = 92.27 kB 89.08 kB = 19.10 kB 18.49 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
facebook-www/React-dev.modern.js +2.54% 52.78 kB 54.12 kB +2.08% 11.83 kB 12.07 kB
facebook-www/React-dev.classic.js +2.54% 52.78 kB 54.12 kB +2.08% 11.83 kB 12.07 kB
facebook-www/ReactDOMServerStreaming-dev.modern.js +0.22% 407.44 kB 408.34 kB +0.25% 73.00 kB 73.18 kB
facebook-www/ReactDOMServer-dev.modern.js +0.22% 408.89 kB 409.78 kB +0.23% 73.48 kB 73.65 kB
facebook-www/ReactDOMServer-dev.classic.js +0.22% 412.33 kB 413.22 kB +0.23% 74.07 kB 74.25 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.development.js = 228.71 kB 224.92 kB = 41.14 kB 40.40 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.development.js = 228.66 kB 224.87 kB = 41.14 kB 40.39 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.unbundled.development.js = 227.45 kB 223.66 kB = 40.84 kB 40.09 kB
oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.development.js = 221.16 kB 217.37 kB = 39.91 kB 39.15 kB
oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.development.js = 221.16 kB 217.37 kB = 39.91 kB 39.15 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.development.js = 221.11 kB 217.32 kB = 39.90 kB 39.14 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.development.js = 221.11 kB 217.32 kB = 39.90 kB 39.14 kB
oss-experimental/react-server-dom-parcel/cjs/react-server-dom-parcel-server.node.development.js = 220.72 kB 216.93 kB = 39.75 kB 39.00 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.unbundled.development.js = 219.90 kB 216.11 kB = 39.61 kB 38.85 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.unbundled.development.js = 219.90 kB 216.11 kB = 39.61 kB 38.85 kB
oss-experimental/react-server-dom-esm/cjs/react-server-dom-esm-server.node.development.js = 214.22 kB 210.43 kB = 39.08 kB 38.33 kB
oss-stable-semver/react-server-dom-parcel/cjs/react-server-dom-parcel-server.node.development.js = 213.17 kB 209.38 kB = 38.49 kB 37.75 kB
oss-stable/react-server-dom-parcel/cjs/react-server-dom-parcel-server.node.development.js = 213.17 kB 209.38 kB = 38.49 kB 37.75 kB
oss-stable-semver/react-server-dom-esm/cjs/react-server-dom-esm-server.node.development.js = 206.67 kB 202.88 kB = 37.80 kB 37.07 kB
oss-stable/react-server-dom-esm/cjs/react-server-dom-esm-server.node.development.js = 206.67 kB 202.88 kB = 37.80 kB 37.07 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.edge.development.js = 201.84 kB 198.05 kB = 36.38 kB 35.62 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.edge.development.js = 201.83 kB 198.05 kB = 36.38 kB 35.62 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.browser.development.js = 198.19 kB 194.40 kB = 35.92 kB 35.15 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.browser.development.js = 197.72 kB 193.93 kB = 35.82 kB 35.05 kB
oss-experimental/react-server-dom-parcel/cjs/react-server-dom-parcel-server.edge.development.js = 193.95 kB 190.17 kB = 35.04 kB 34.26 kB
oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.edge.development.js = 193.91 kB 190.12 kB = 35.09 kB 34.32 kB
oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.edge.development.js = 193.91 kB 190.12 kB = 35.09 kB 34.32 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.edge.development.js = 193.91 kB 190.12 kB = 35.08 kB 34.31 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.edge.development.js = 193.91 kB 190.12 kB = 35.08 kB 34.31 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.browser.development.js = 190.62 kB 186.83 kB = 34.68 kB 33.91 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.browser.development.js = 190.62 kB 186.83 kB = 34.68 kB 33.91 kB
oss-experimental/react-server-dom-parcel/cjs/react-server-dom-parcel-server.browser.development.js = 189.87 kB 186.09 kB = 34.46 kB 33.67 kB
oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.browser.development.js = 190.15 kB 186.36 kB = 34.58 kB 33.82 kB
oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.browser.development.js = 190.15 kB 186.36 kB = 34.58 kB 33.82 kB
oss-stable-semver/react-server-dom-parcel/cjs/react-server-dom-parcel-server.edge.development.js = 186.03 kB 182.24 kB = 33.71 kB 32.99 kB
oss-stable/react-server-dom-parcel/cjs/react-server-dom-parcel-server.edge.development.js = 186.03 kB 182.24 kB = 33.71 kB 32.99 kB
oss-stable-semver/react-server-dom-parcel/cjs/react-server-dom-parcel-server.browser.development.js = 182.30 kB 178.51 kB = 33.22 kB 32.48 kB
oss-stable/react-server-dom-parcel/cjs/react-server-dom-parcel-server.browser.development.js = 182.30 kB 178.51 kB = 33.22 kB 32.48 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.production.js = 112.46 kB 109.27 kB = 22.45 kB 21.85 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.production.js = 112.44 kB 109.25 kB = 22.45 kB 21.84 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.unbundled.production.js = 111.39 kB 108.19 kB = 22.23 kB 21.62 kB
oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.production.js = 106.97 kB 103.77 kB = 21.53 kB 20.91 kB
oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.production.js = 106.97 kB 103.77 kB = 21.53 kB 20.91 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.production.js = 106.94 kB 103.75 kB = 21.52 kB 20.90 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.production.js = 106.94 kB 103.75 kB = 21.52 kB 20.90 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.edge.production.js = 106.17 kB 102.97 kB = 21.45 kB 20.84 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.edge.production.js = 106.17 kB 102.97 kB = 21.45 kB 20.85 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.unbundled.production.js = 105.89 kB 102.70 kB = 21.31 kB 20.69 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.unbundled.production.js = 105.89 kB 102.70 kB = 21.31 kB 20.69 kB
oss-experimental/react-server-dom-parcel/cjs/react-server-dom-parcel-server.node.production.js = 105.31 kB 102.12 kB = 21.20 kB 20.57 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.browser.production.js = 105.21 kB 102.02 kB = 21.23 kB 20.63 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.browser.production.js = 104.86 kB 101.67 kB = 21.13 kB 20.53 kB
oss-experimental/react-server-dom-esm/cjs/react-server-dom-esm-server.node.production.js = 101.39 kB 98.19 kB = 20.75 kB 20.14 kB
oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.edge.production.js = 100.55 kB 97.36 kB = 20.53 kB 19.92 kB
oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.edge.production.js = 100.55 kB 97.36 kB = 20.53 kB 19.92 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.edge.production.js = 100.55 kB 97.36 kB = 20.53 kB 19.92 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.edge.production.js = 100.55 kB 97.36 kB = 20.53 kB 19.92 kB
oss-stable-semver/react-server-dom-parcel/cjs/react-server-dom-parcel-server.node.production.js = 99.82 kB 96.62 kB = 20.33 kB 19.72 kB
oss-stable/react-server-dom-parcel/cjs/react-server-dom-parcel-server.node.production.js = 99.82 kB 96.62 kB = 20.33 kB 19.72 kB
oss-stable-semver/react-server-dom-webpack/cjs/react-server-dom-webpack-server.browser.production.js = 99.69 kB 96.49 kB = 20.33 kB 19.72 kB
oss-stable/react-server-dom-webpack/cjs/react-server-dom-webpack-server.browser.production.js = 99.69 kB 96.49 kB = 20.33 kB 19.72 kB
oss-stable-semver/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.browser.production.js = 99.33 kB 96.14 kB = 20.24 kB 19.63 kB
oss-stable/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.browser.production.js = 99.33 kB 96.14 kB = 20.24 kB 19.63 kB
oss-experimental/react-server-dom-parcel/cjs/react-server-dom-parcel-server.edge.production.js = 99.09 kB 95.89 kB = 20.23 kB 19.61 kB
oss-experimental/react-server-dom-parcel/cjs/react-server-dom-parcel-server.browser.production.js = 97.80 kB 94.61 kB = 19.94 kB 19.34 kB
oss-stable-semver/react-server-dom-esm/cjs/react-server-dom-esm-server.node.production.js = 95.89 kB 92.70 kB = 19.85 kB 19.25 kB
oss-stable/react-server-dom-esm/cjs/react-server-dom-esm-server.node.production.js = 95.89 kB 92.70 kB = 19.85 kB 19.25 kB
oss-stable-semver/react-server-dom-parcel/cjs/react-server-dom-parcel-server.edge.production.js = 93.47 kB 90.28 kB = 19.37 kB 18.75 kB
oss-stable/react-server-dom-parcel/cjs/react-server-dom-parcel-server.edge.production.js = 93.47 kB 90.28 kB = 19.37 kB 18.75 kB
oss-stable-semver/react-server-dom-parcel/cjs/react-server-dom-parcel-server.browser.production.js = 92.27 kB 89.08 kB = 19.10 kB 18.49 kB
oss-stable/react-server-dom-parcel/cjs/react-server-dom-parcel-server.browser.production.js = 92.27 kB 89.08 kB = 19.10 kB 18.49 kB

Generated by 🚫 dangerJS against 6c082ec

@hoxyq hoxyq force-pushed the enableAsyncDebugInfo-dynamic branch from f58b013 to 3110bdb Compare September 10, 2025 17:42
@hoxyq hoxyq force-pushed the enableAsyncDebugInfo-dynamic branch 7 times, most recently from 65e2950 to af8a4cc Compare September 26, 2025 15:31
@hoxyq hoxyq force-pushed the enableAsyncDebugInfo-dynamic branch from af8a4cc to 6c082ec Compare September 26, 2025 15:36
@hoxyq hoxyq merged commit c552618 into facebook:main Sep 26, 2025
241 checks passed
@hoxyq hoxyq deleted the enableAsyncDebugInfo-dynamic branch September 26, 2025 18:43
github-actions bot pushed a commit that referenced this pull request Sep 26, 2025
@hoxyq
flags: make enableAsyncDebugInfo dynamic for www (#34430)
adc2116 
As titled. This adds dev-only debugging information to Fizz / Flight
that could be used for tracking Promise's stack traces in "suspended by"
section of DevTools.

DiffTrain build for [c552618](c552618)
sebmarkbage pushed a commit to sebmarkbage/react that referenced this pull request Sep 26, 2025
@hoxyq @sebmarkbage
flags: make enableAsyncDebugInfo dynamic for www (facebook#34430)
0b7e549 
As titled. This adds dev-only debugging information to Fizz / Flight
that could be used for tracking Promise's stack traces in "suspended by"
section of DevTools.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gnoff gnoff gnoff approved these changes

@jackpope jackpope jackpope approved these changes

@kassens kassens Awaiting requested review from kassens

@rickhanlonii rickhanlonii Awaiting requested review from rickhanlonii

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hoxyq @react-sizebot @gnoff @jackpope