-
-
Notifications
You must be signed in to change notification settings - Fork 7.2k
Replace plaintext auth tokens with HttpOnly cookies #1606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…oken in plain text
…-only cookie on logout
b0cb31b
to
71affa9
Compare
what happens to the swagger docs using this implementation. when we want authenticate it seems like pasting any text it authorizes automatically no request is sent to the server. |
After some reserach i found this https://swagger.io/docs/specification/v3_0/authentication/cookie-authentication/ |
This pull request has a merge conflict that needs to be resolved. |
Overview
Currently authentication tokens are sent in plain text format. This can be a security vulnerability because attackers can run malicious JS scripts in the browser to access the user's token and perform session hijacking. A recommended solution for this vulnerability is to send auth tokens in a Cookie with the HttpOnly flag set. HttpOnly cookies’ content is not accessible from JavaScript, preventing XSS attacks from stealing these tokens.
Backend changes:
create_access_token
function to generate the JWT token but instead of returning it directly in the/login
endpoint, we return a JSONResponse with an http-only cookie, which contains the token.get_current_user
function, now there is anAPIKeyCookie
dependency, but the way we decode the JWT token didn't change./logout
endpoint which deletes the cookie.Frontend changes:
withCredentials=true
parameter to include the cookies in the requestsaccess_token
inlocalStorage
(the token is not accessible from JS anymore), now we store theis_authenticated
boolean value and use it to check authentication and remove it during logoutBefore:
After: