Skip to content

Conversation

svlandeg
Copy link
Member

@svlandeg svlandeg commented Sep 1, 2025

  • Label a PR that has merge conflicts with the new label "conflicts"
  • Add a comment to the PR to alert the original poster & any subscribers to the thread
  • Remove the label again when the conflict is resolved (but no further comment)

with:
dirtyLabel: "conflicts"
repoToken: "${{ secrets.GITHUB_TOKEN }}"
commentOnDirty: "This pull request has a merge conflict that needs to be resolved."
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can also remove this line, then no comment will be posted, only the label will be added.
I think posting a comment will be helpful though, both for the original poster as well as for maintainers who have worked on the PR and are subscribed to it.

Copy link
Member

@tiangolo tiangolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Let's do it! 🚀

@tiangolo tiangolo merged commit dd3c6aa into fastapi:master Sep 1, 2025
24 checks passed
@svlandeg svlandeg deleted the feature/conflict branch September 1, 2025 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants