Fix: Fixed crash that sometimes occurred when opening pinned items #17611
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0x5bfa
reviewed
Sep 15, 2025
| @@ -105,7 +105,7 @@ private void ReloadWidgets() | |||
|
|
|||
| public void RefreshWidgetList() | |||
| { | |||
| for (int i = 0; i < WidgetItems.Count; i++) | |||
There was a problem hiding this comment.
Backward iteration avoids skipped items from index shifts and works safely with DispatcherQueue UI updates.
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a crash that occurs when users click on pinned items in the left panel before a tab completes loading. The fix ensures that WidgetItems collection is accessed only on the UI thread to prevent cross-thread access violations.
Key changes:
- Wraps all WidgetItems collection operations in UI thread dispatching
- Fixes iteration direction in RefreshWidgetList to handle collection modifications
- Improves thread safety for widget management operations
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
yaira2
changed the title
yaira2
changed the title
yaira2
added
ready to merge
yaira2
approved these changes
Sep 16, 2025
yaira2
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved / Related Issues
Closes #17539
Fixed the crash by ensuring the WidgetItems is accessed only on the UI thread.
Steps used to test these changes