Skip to content

Commit fe4971f

Browse files
hsubox76hsubox76
authored
Remove objectHashIgnoreUnknownHack (#2977)
1 parent 1ae13d1 commit fe4971f

File tree

5 files changed

+6
-78
lines changed

5 files changed

+6
-78
lines changed

‎packages-exp/firebase-exp/package.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@
4242
"rollup-plugin-node-resolve": "5.2.0",
4343
"rollup-plugin-sourcemaps": "0.5.0",
4444
"rollup-plugin-terser": "5.1.3",
45-
"rollup-plugin-typescript2": "0.25.3",
45+
"rollup-plugin-typescript2": "0.27.0",
4646
"rollup-plugin-uglify": "6.0.4",
4747
"gulp": "4.0.2",
4848
"gulp-sourcemaps": "2.6.5",

‎packages-exp/firebase-exp/rollup.config.js‎

Lines changed: 1 addition & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -68,23 +68,11 @@ function createUmdOutputConfig(output, componentName) {
6868
const plugins = [sourcemaps(), resolveModule(), json(), commonjs()];
6969

7070
const typescriptPlugin = rollupTypescriptPlugin({
71-
typescript,
72-
// Workaround for typescript plugins that use async functions.
73-
// In this case, `rollup-plugin-sourcemaps`.
74-
// See https://github.com/ezolenko/rollup-plugin-typescript2/blob/master/README.md
75-
objectHashIgnoreUnknownHack: true,
76-
// For safety, given hack above (see link).
77-
clean: true
71+
typescript
7872
});
7973

8074
const typescriptPluginUMD = rollupTypescriptPlugin({
8175
typescript,
82-
// Workaround for typescript plugins that use async functions.
83-
// In this case, `rollup-plugin-sourcemaps`.
84-
// See https://github.com/ezolenko/rollup-plugin-typescript2/blob/master/README.md
85-
objectHashIgnoreUnknownHack: true,
86-
// For safety, given hack above (see link).
87-
clean: true,
8876
tsconfigOverride: {
8977
compilerOptions: {
9078
declaration: false

‎packages-exp/firebase-exp/rollup.config.release.js‎

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -73,23 +73,11 @@ const plugins = [sourcemaps(), resolveModule(), json(), commonjs()];
7373

7474
const typescriptPlugin = rollupTypescriptPlugin({
7575
typescript,
76-
// Workaround for typescript plugins that use async functions.
77-
// In this case, `rollup-plugin-sourcemaps`.
78-
// See https://github.com/ezolenko/rollup-plugin-typescript2/blob/master/README.md
79-
objectHashIgnoreUnknownHack: true,
80-
// For safety, given hack above (see link).
81-
clean: true,
8276
transformers: [importPathTransformer]
8377
});
8478

8579
const typescriptPluginUMD = rollupTypescriptPlugin({
8680
typescript,
87-
// Workaround for typescript plugins that use async functions.
88-
// In this case, `rollup-plugin-sourcemaps`.
89-
// See https://github.com/ezolenko/rollup-plugin-typescript2/blob/master/README.md
90-
objectHashIgnoreUnknownHack: true,
91-
// For safety, given hack above (see link).
92-
clean: true,
9381
tsconfigOverride: {
9482
compilerOptions: {
9583
declaration: false

‎packages/firebase/rollup.config.js‎

Lines changed: 3 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
/**
22
* @license
3-
* Copyright 2018 Google Inc.
3+
* Copyright 2018 Google LLC
44
*
55
* Licensed under the Apache License, Version 2.0 (the "License");
66
* you may not use this file except in compliance with the License.
@@ -64,13 +64,7 @@ const plugins = [
6464
sourcemaps(),
6565
resolveModule(),
6666
typescriptPlugin({
67-
typescript,
68-
// Workaround for typescript plugins that use async functions.
69-
// In this case, `rollup-plugin-sourcemaps`.
70-
// See https://github.com/ezolenko/rollup-plugin-typescript2/blob/master/README.md
71-
objectHashIgnoreUnknownHack: true,
72-
// For safety, given hack above (see link).
73-
clean: true
67+
typescript
7468
}),
7569
json(),
7670
commonjs()
@@ -234,13 +228,7 @@ const completeBuilds = [
234228
mainFields: ['lite', 'module', 'main']
235229
}),
236230
typescriptPlugin({
237-
typescript,
238-
// Workaround for typescript plugins that use async functions.
239-
// In this case, `rollup-plugin-sourcemaps`.
240-
// See https://github.com/ezolenko/rollup-plugin-typescript2/blob/master/README.md
241-
objectHashIgnoreUnknownHack: true,
242-
// For safety, given hack above (see link).
243-
clean: true
231+
typescript
244232
}),
245233
json(),
246234
commonjs(),
@@ -265,12 +253,6 @@ const completeBuilds = [
265253
}),
266254
typescriptPlugin({
267255
typescript,
268-
// Workaround for typescript plugins that use async functions.
269-
// In this case, `rollup-plugin-sourcemaps`.
270-
// See https://github.com/ezolenko/rollup-plugin-typescript2/blob/master/README.md
271-
objectHashIgnoreUnknownHack: true,
272-
// For safety, given hack above (see link).
273-
clean: true,
274256
tsconfigOverride: {
275257
compilerOptions: {
276258
target: 'es2017'

‎yarn.lock‎

Lines changed: 1 addition & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -6320,7 +6320,7 @@ find-cache-dir@^2.1.0:
63206320
make-dir "^2.0.0"
63216321
pkg-dir "^3.0.0"
63226322

6323-
find-cache-dir@^3.0.0, find-cache-dir@^3.2.0, find-cache-dir@^3.3.1:
6323+
find-cache-dir@^3.2.0, find-cache-dir@^3.3.1:
63246324
version "3.3.1"
63256325
resolved "https://registry.npmjs.org/find-cache-dir/-/find-cache-dir-3.3.1.tgz#89b33fad4a4670daa94f855f7fbe31d6d84fe880"
63266326
integrity sha512-t2GDMt3oGC/v+BMwzmllWDuJF/xcDtE5j/fCGbqDD7OLuJkj0cfh1YSA5VKPvwMeLFLNDBkwOKZ2X85jGLVftQ==
@@ -12378,13 +12378,6 @@ [email protected]:
1237812378
resolved "https://registry.npmjs.org/resolve/-/resolve-1.1.7.tgz#203114d82ad2c5ed9e8e0411b3932875e889e97b"
1237912379
integrity sha1-IDEU2CrSxe2ejgQRs5ModeiJ6Xs=
1238012380

12381-
[email protected]:
12382-
version "1.12.0"
12383-
resolved "https://registry.npmjs.org/resolve/-/resolve-1.12.0.tgz#3fc644a35c84a48554609ff26ec52b66fa577df6"
12384-
integrity sha512-B/dOmuoAik5bKcD6s6nXDCjzUKnaDvdkRyAk6rsmsKLipWj4797iothd7jmmUhWTfinVMU+wc56rYKsit2Qy4w==
12385-
dependencies:
12386-
path-parse "^1.0.6"
12387-
1238812381
[email protected], resolve@^1.1.4, resolve@^1.1.6, resolve@^1.1.7, resolve@^1.10.0, resolve@^1.11.0, resolve@^1.11.1, resolve@^1.12.0, resolve@^1.13.1, resolve@^1.3.2, resolve@^1.3.3, resolve@^1.4.0:
1238912382
version "1.15.1"
1239012383
resolved "https://registry.npmjs.org/resolve/-/resolve-1.15.1.tgz#27bdcdeffeaf2d6244b95bb0f9f4b4653451f3e8"
@@ -12579,17 +12572,6 @@ [email protected]:
1257912572
serialize-javascript "^2.1.2"
1258012573
terser "^4.6.2"
1258112574

12582-
[email protected]:
12583-
version "0.25.3"
12584-
resolved "https://registry.npmjs.org/rollup-plugin-typescript2/-/rollup-plugin-typescript2-0.25.3.tgz#a5fb2f0f85488789334ce540abe6c7011cbdf40f"
12585-
integrity sha512-ADkSaidKBovJmf5VBnZBZe+WzaZwofuvYdzGAKTN/J4hN7QJCFYAq7IrH9caxlru6T5qhX41PNFS1S4HqhsGQg==
12586-
dependencies:
12587-
find-cache-dir "^3.0.0"
12588-
fs-extra "8.1.0"
12589-
resolve "1.12.0"
12590-
rollup-pluginutils "2.8.1"
12591-
tslib "1.10.0"
12592-
1259312575
[email protected]:
1259412576
version "0.27.0"
1259512577
resolved "https://registry.npmjs.org/rollup-plugin-typescript2/-/rollup-plugin-typescript2-0.27.0.tgz#95ff96f9e07d5000a9d2df4d76b548f9a1f83511"
@@ -12611,13 +12593,6 @@ [email protected]:
1261112593
serialize-javascript "^2.1.2"
1261212594
uglify-js "^3.4.9"
1261312595

12614-
[email protected]:
12615-
version "2.8.1"
12616-
resolved "https://registry.npmjs.org/rollup-pluginutils/-/rollup-pluginutils-2.8.1.tgz#8fa6dd0697344938ef26c2c09d2488ce9e33ce97"
12617-
integrity sha512-J5oAoysWar6GuZo0s+3bZ6sVZAC0pfqKz68De7ZgDi5z63jOVZn1uJL/+z1jeKHNbGII8kAyHF5q8LnxSX5lQg==
12618-
dependencies:
12619-
estree-walker "^0.6.1"
12620-
1262112596
rollup-pluginutils@^2.5.0, rollup-pluginutils@^2.6.0, rollup-pluginutils@^2.8.1, rollup-pluginutils@^2.8.2:
1262212597
version "2.8.2"
1262312598
resolved "https://registry.npmjs.org/rollup-pluginutils/-/rollup-pluginutils-2.8.2.tgz#72f2af0748b592364dbd3389e600e5a9444a351e"
@@ -14236,11 +14211,6 @@ [email protected]:
1423614211
source-map-support "^0.5.6"
1423714212
yn "3.1.1"
1423814213

14239-
[email protected]:
14240-
version "1.10.0"
14241-
resolved "https://registry.npmjs.org/tslib/-/tslib-1.10.0.tgz#c3c19f95973fb0a62973fb09d90d961ee43e5c8a"
14242-
integrity sha512-qOebF53frne81cf0S9B41ByenJ3/IuH8yJKngAX35CmiZySA0khhkovshKK+jGCaMnVomla7gVlIcc3EvKPbTQ==
14243-
1424414214
[email protected], tslib@^1.10.0, tslib@^1.8.1, tslib@^1.9.0:
1424514215
version "1.11.1"
1424614216
resolved "https://registry.npmjs.org/tslib/-/tslib-1.11.1.tgz#eb15d128827fbee2841549e171f45ed338ac7e35"

0 commit comments

Comments
 (0)