Skip to content

Remove objectHashIgnoreUnknownHack #2977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 23, 2020
Merged

Remove objectHashIgnoreUnknownHack #2977

merged 2 commits into from
Apr 23, 2020

Conversation

hsubox76
Copy link
Contributor

This hack is no longer needed as of rollup-plugin-typescript2 version 0.26.0 and we are on 0.27.0.

yarn build and yarn build:exp succeeded after removal.

ezolenko/rollup-plugin-typescript2#203

@google-oss-bot
Copy link
Contributor

Binary Size Report

Affected SDKs

No changes between base commit (1ae13d1) and head commit (ba81b52).

Test Logs

@hsubox76 hsubox76 merged commit fe4971f into master Apr 23, 2020
@firebase firebase locked and limited conversation to collaborators May 24, 2020
@hsubox76 hsubox76 deleted the ch-rollup branch June 18, 2020 21:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hiranya911 hiranya911 Awaiting requested review from hiranya911

1 more reviewer

@Feiyang1 Feiyang1 Feiyang1 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hsubox76 @google-oss-bot @Feiyang1