feat: Add GA4 tracking for Gemini CLI extension #9124
Conversation
![google-labs-jules[bot]](https://avatars.githubusercontent.com/in/842251?s=60&v=4){kind=small}
This change adds a new parameter `gemini_cli_extension` to the MCP GA4 tracking when the `experimental:mcp` command is run. This parameter is set to "true" when the `IS_GEMINI_CLI_EXTENSION` environment variable is set, and "false" otherwise. This will allow us to track the usage of the Gemini CLI extension.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll acknowledge your comments with a 👀 emoji and then get to work. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! I will automatically address your feedback. For any comments you don't want me to act on, just include (aside). For security, I will only act on instructions from the user who triggered this task for this pull request. |
src/mcp/index.spec.ts
Outdated
| it("should return email when authenticated user is present", async () => { | ||
| const testEmail = "[email protected]"; | ||
| requireAuthStub.resolves(testEmail); | ||
| describe("trackGA4", () => { |
There was a problem hiding this comment.
Please remove this test and revert the change to this file - it is excessive to test this private method.
There was a problem hiding this comment.
I have removed the tests for the private method and reverted the changes to the test file as requested.
This change adds a new parameter `gemini_cli_extension` to the MCP GA4 tracking when the `experimental:mcp` command is run. This parameter is set to "true" when the `IS_GEMINI_CLI_EXTENSION` environment variable is set, and "false" otherwise. This will allow us to track the usage of the Gemini CLI extension. (tests for private method removed per PR feedback)
github-project-automation
bot
moved this to Approved [PR]
in [Cloud] Extensions + Functions
github-project-automation
bot
moved this from Approved [PR]
to Done
in [Cloud] Extensions + Functions
This change adds a new parameter
gemini_cli_extensionto the MCP GA4 tracking when theexperimental:mcpcommand is run. This parameter is set to "true" when theIS_GEMINI_CLI_EXTENSIONenvironment variable is set, and "false" otherwise.This will allow us to track the usage of the Gemini CLI extension.
PR created automatically by Jules for task 18075266203534249222