Skip to content

Conversation

cynthiajoan
Copy link
Collaborator

This change expands the error summarization feature to all relevant jobs in the CI workflow. Previously, it was only applied to the test job.

  • The summarize_errors.sh script has been generalized to accept a search pattern, making it reusable for different jobs.
  • The all_plugins.yaml workflow has been updated to add error summarization to the analyze, format, pub_dry_run, and check-files-license-headers jobs.
  • The test job's summarization step has been updated to use the new generalized script correctly.
  • The melos.yaml file has been updated to remove the --fail-fast flag from the test and test:web scripts, allowing for a complete summary of all test failures.

Description

Replace this paragraph with a description of what this PR is doing. If you're modifying existing behavior, describe the existing behavior, how this PR is changing it, and what motivated the change.

Related Issues

Replace this paragraph with a list of issues related to this PR from the issue database. Indicate, which of these issues are resolved or fixed by this PR. Note that you'll have to prefix the issue numbers with flutter/flutter#.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

This change expands the error summarization feature to all relevant jobs in the CI workflow. Previously, it was only applied to the `test` job.

- The `summarize_errors.sh` script has been generalized to accept a search pattern, making it reusable for different jobs.
- The `all_plugins.yaml` workflow has been updated to add error summarization to the `analyze`, `format`, `pub_dry_run`, and `check-files-license-headers` jobs.
- The `test` job's summarization step has been updated to use the new generalized script correctly.
- The `melos.yaml` file has been updated to remove the `--fail-fast` flag from the `test` and `test:web` scripts, allowing for a complete summary of all test failures.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant