Fix devtool strip #2567
Merged
Fix devtool strip #2567
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alindima
previously approved these changes
May 17, 2021
tools/devtool
Outdated
| # 1. devtool -y test | ||
| # 2. devtool -y build --release | ||
| # 3. devtool strip | ||
| cmd_ci() { |
There was a problem hiding this comment.
This is to use in our CI pipelines?
There was a problem hiding this comment.
Yep, we should test that a PR also doesn't break the release steps, whatever those steps are.
| @@ -775,13 +775,13 @@ cmd_strip() { | |||
| strip $strip_flags\ | |||
| "$CTR_CARGO_TARGET_DIR/$target/$profile/firecracker" \ | |||
| "$CTR_CARGO_TARGET_DIR/$target/$profile/jailer" \ | |||
| "$CTR_CARGO_TARGET_DIR/$target/$profile/seccompiler/seccompiler" | |||
| "$CTR_CARGO_SECCOMPILER_TARGET_DIR/$target/$profile/seccompiler" | |||
|
Given this a second thought and we need to enable proper flexibility when testing with the I'll remove the |
added 2 commits
May 17, 2021 18:50
When stripping binaries, the path pointing to the seccompiler binary was incorrect. Since we're putting the seccomp binary in a different location than standard binaries, this commit also adds a message for where to find the stripped seccompiler binary. Signed-off-by: Gabriel Ionescu <[email protected]>
Signed-off-by: Gabriel Ionescu <[email protected]>
acatangiu
approved these changes
May 18, 2021
alindima
approved these changes
May 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for This PR
./devtool stripwas failing due to incorrect path.Description of Changes
Fix strip command and add a command called
cito use to test the release process end to end.rust-vmm.License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license.
PR Checklist
[Author TODO: Meet these criteria.][Reviewer TODO: Verify that these criteria are met. Request changes if not]git commit -s).unsafecode is properly documented.firecracker/swagger.yaml.CHANGELOG.md.