feat(share_plus): Show destination for share with result in example, update example UI #1314
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vbuberen
added
the
share_plus
miquelbeltran
approved these changes
Nov 1, 2022
nohli
approved these changes
Nov 1, 2022
nohli
reviewed
Nov 1, 2022
| scaffoldMessenger.showSnackBar(getResultSnackBar(shareResult)); | ||
| } | ||
|
|
||
| SnackBar getResultSnackBar(ShareResult result) { |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Saw that example app for
share_plusshows only type of result in case withshareWithResultcall, but not the destination. So adding a destination info as well to showcase the feature better for package users.Additionally decided to give the example app UI a little visual improvement, so made it to use Material 3 and did small changes to make it look more modern and clean to use:
Checklist
CHANGELOG.mdnor thepubspec.yamlfiles.flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?
!in the title as explained in Conventional Commits).