Skip to content

Conversation

Manas-kashyap
Copy link
Contributor

@Manas-kashyap Manas-kashyap commented Dec 26, 2018

Fixes #31
Checklist
I have read the Contribution & Best practices Guide and my PR follows them.
My branch is up-to-date with the Upstream master branch.
I have added necessary documentation (if appropriate)
Added brief description
Changes proposed in this pull request:
Change done in debian/control adding extended description

Thank you!

@ghost ghost added the needs-review label Dec 26, 2018
@ghost ghost assigned Manas-kashyap Dec 26, 2018
@@ -10,3 +10,8 @@ Package: systemlock
Architecture: all
Depends: ${shlibs:Depends}, ${misc:Depends}
Description: Interface for ofris.
.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This first line is not required;
Add one space indentation in the second line
The last line is not required; the second line is sufficient

@@ -10,3 +10,8 @@ Package: systemlock
Architecture: all
Depends: ${shlibs:Depends}, ${misc:Depends}
Description: Interface for ofris.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While you are revising this: What is "ofris" btw?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ofris its given by @pranav1698 before hand.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am aware it is not your line.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, ??

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ofris was in the control file before I made the changes,
I think it means it gives the interface to deep freeze application for ubuntu that is offris
www.webupd8.org/2010/08/ofris-deep-freeze-like-application-for.html

Copy link

@pranav1698 pranav1698 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have rebased it fine, just do the recommended changes

@ghost ghost removed the needs-review label Jan 3, 2019
Copy link

@pranav1698 pranav1698 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@meets2tarun @abishekvashok @tabesin please review and merge this pr

Copy link

@pranav1698 pranav1698 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tabesin please review and merge this one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants