-
Notifications
You must be signed in to change notification settings - Fork 18
extended description added , resolving #31 #37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
systemlock-0.1/debian/control
Outdated
@@ -10,3 +10,8 @@ Package: systemlock | |||
Architecture: all | |||
Depends: ${shlibs:Depends}, ${misc:Depends} | |||
Description: Interface for ofris. | |||
. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This first line is not required;
Add one space indentation in the second line
The last line is not required; the second line is sufficient
systemlock-0.1/debian/control
Outdated
@@ -10,3 +10,8 @@ Package: systemlock | |||
Architecture: all | |||
Depends: ${shlibs:Depends}, ${misc:Depends} | |||
Description: Interface for ofris. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While you are revising this: What is "ofris" btw?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ofris its given by @pranav1698 before hand.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am aware it is not your line.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, ??
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ofris was in the control file before I made the changes,
I think it means it gives the interface to deep freeze application for ubuntu that is offris
www.webupd8.org/2010/08/ofris-deep-freeze-like-application-for.html
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have rebased it fine, just do the recommended changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@meets2tarun @abishekvashok @tabesin please review and merge this pr
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tabesin please review and merge this one
Fixes #31
Checklist
I have read the Contribution & Best practices Guide and my PR follows them.
My branch is up-to-date with the Upstream master branch.
I have added necessary documentation (if appropriate)
Added brief description
Changes proposed in this pull request:
Change done in debian/control adding extended description
Thank you!