[WIP-RFC] Inspect EIP-7201 bucket Schema #11429

tom2o17 · 2025-08-26T16:19:42Z

Motivation

Fixes #7662
Adds support for EIP-7201 storage bucket declarations support w/n
forge inspect PATH:Contract storageLayout table

Before

tc@TCs-MacBook-Pro frxAccount-EIP7702 % forge inspect src/FrxCommerce.sol:FrxCommerceAccount storageLayout
Warning: This is a nightly build of Foundry. It is recommended to use the latest stable version. To mute this warning set `FOUNDRY_DISABLE_NIGHTLY_WARNING` in your environment. 


╭------+------+------+--------+-------+----------╮
| Name | Type | Slot | Offset | Bytes | Contract |
+================================================+
╰------+------+------+--------+-------+----------╯

tc@TCs-MacBook-Pro frxAccount-EIP7702 % forge inspect src/FrxCommerce.sol:FrxCommerceAccount storageLayout
tc@TCs-MacBook-Pro frxAccount-EIP7702 % 
tc@TCs-MacBook-Pro frxAccount-EIP7702 % 
tc@TCs-MacBook-Pro frxAccount-EIP7702 % /Users/tc/Documents/GitHub/foundry/target/debug/forge inspect src/FrxCommerce.sol:FrxCommerceAccount storageLayout

╭----------------+----------------------+---------------+--------+-------+---------------╮
| Name           | Type                 | Slot          | Offset | Bytes | Contract      |
+========================================================================================+
| storage-bucket | struct EIP712Storage | 0xa16a46…d100 | 0      | 32    | EIP712Storage |
|----------------+----------------------+---------------+--------+-------+---------------|
| storage-bucket | struct NoncesStorage | 0x5ab42c…bb00 | 0      | 32    | NoncesStorage |
╰----------------+----------------------+---------------+--------+-------+---------------╯

Usage buckets ought to be declared above the empty constructor argument for the implementation contract to be set for a given proxy eg:

    /// @custom:storage-bucket EIP712Storage 0xa16a46d94261c7517cc8ff89f61c0ce93598e3c849801011dee649a6a557d100
    /// @custom:storage-bucket NoncesStorage 0x5ab42ced628888259c08ac98db1eb0cf702fc1501344311d8b100cd1bfe4bb00
  constructor() {
    _disableInitializers();
  }

Solution

Add support for w/n the foundry solc artifact parsing, to support these tags. This ensures that storage declared via name-spacing is visible to the end developer

PR Checklist

Added Tests
Added Documentation
Breaking changes

Disclaimers

Work in progress / request for comment
Very open to collaborating on changes, relatively new to rust

grandizzy

thank you! I think this makes sense (not familiar with EIP-7201 but the regex matches in my initial pass through) left some comments, also could you please add an unit test with the sample you posted in description?

grandizzy · 2025-08-28T09:23:41Z

crates/forge/src/cmd/inspect.rs

+        .collect()
+}
+
+fn short_hex(h: &str) -> String {


I don't think we should short this, is that a big issue if we display it entirely?

No, it just distorts the table render.

This is the difference in outputs

tc@TCs-MacBook-Pro frxAccount-EIP7702 % /Users/tc/Documents/GitHub/foundry/target/debug/forge inspect src/FrxCommerce.sol:FrxCommerceAccount storageLayout ╭----------------+----------------------+---------------+--------+-------+---------------╮ | Name | Type | Slot | Offset | Bytes | Contract | +========================================================================================+ | storage-bucket | struct EIP712Storage | 0xa16a46…d100 | 0 | 32 | EIP712Storage | |----------------+----------------------+---------------+--------+-------+---------------| | storage-bucket | struct NoncesStorage | 0x5ab42c…bb00 | 0 | 32 | NoncesStorage | ╰----------------+----------------------+---------------+--------+-------+---------------╯ tc@TCs-MacBook-Pro frxAccount-EIP7702 % /Users/tc/Documents/GitHub/foundry/target/debug/forge inspect src/FrxCommerce.sol:FrxCommerceAccount storageLayout ╭----------------+----------------------+--------------------------------------------------------------------+--------+-------+---------------╮ | Name | Type | Slot | Offset | Bytes | Contract | +=============================================================================================================================================+ | storage-bucket | struct EIP712Storage | 0xa16a46d94261c7517cc8ff89f61c0ce93598e3c849801011dee649a6a557d100 | 0 | 32 | EIP712Storage | |----------------+----------------------+--------------------------------------------------------------------+--------+-------+---------------| | storage-bucket | struct NoncesStorage | 0x5ab42ced628888259c08ac98db1eb0cf702fc1501344311d8b100cd1bfe4bb00 | 0 | 32 | NoncesStorage | ╰----------------+----------------------+--------------------------------------------------------------------+--------+-------+---------------╯

Personally prefer the former but can change if you feel strongly

I see, then maybe we could reuse

foundry/crates/evm/core/src/decode.rs

Line 227 in e6098ac

fn trimmed_hex(s: &[u8]) -> String {

@DaniPopes @zerosnacks wdyt?

crates/forge/src/cmd/inspect.rs

tom2o17

Comments less the short hex change should be implemented.

If you feel strongly about the non-short hex lmk and will change.
Otherwise the bytes32 makes the table a little wide which messes up the formatting if the terminal window is small.

tom2o17 · 2025-08-28T14:30:31Z

crates/forge/src/cmd/inspect.rs

+        .collect()
+}
+
+fn short_hex(h: &str) -> String {


No, it just distorts the table render.

This is the difference in outputs

tc@TCs-MacBook-Pro frxAccount-EIP7702 % /Users/tc/Documents/GitHub/foundry/target/debug/forge inspect src/FrxCommerce.sol:FrxCommerceAccount storageLayout ╭----------------+----------------------+---------------+--------+-------+---------------╮ | Name | Type | Slot | Offset | Bytes | Contract | +========================================================================================+ | storage-bucket | struct EIP712Storage | 0xa16a46…d100 | 0 | 32 | EIP712Storage | |----------------+----------------------+---------------+--------+-------+---------------| | storage-bucket | struct NoncesStorage | 0x5ab42c…bb00 | 0 | 32 | NoncesStorage | ╰----------------+----------------------+---------------+--------+-------+---------------╯ tc@TCs-MacBook-Pro frxAccount-EIP7702 % /Users/tc/Documents/GitHub/foundry/target/debug/forge inspect src/FrxCommerce.sol:FrxCommerceAccount storageLayout ╭----------------+----------------------+--------------------------------------------------------------------+--------+-------+---------------╮ | Name | Type | Slot | Offset | Bytes | Contract | +=============================================================================================================================================+ | storage-bucket | struct EIP712Storage | 0xa16a46d94261c7517cc8ff89f61c0ce93598e3c849801011dee649a6a557d100 | 0 | 32 | EIP712Storage | |----------------+----------------------+--------------------------------------------------------------------+--------+-------+---------------| | storage-bucket | struct NoncesStorage | 0x5ab42ced628888259c08ac98db1eb0cf702fc1501344311d8b100cd1bfe4bb00 | 0 | 32 | NoncesStorage | ╰----------------+----------------------+--------------------------------------------------------------------+--------+-------+---------------╯

Personally prefer the former but can change if you feel strongly

crates/forge/src/cmd/inspect.rs

grandizzy · 2025-08-29T07:27:54Z

crates/forge/src/cmd/inspect.rs

+        .collect()
+}
+
+fn short_hex(h: &str) -> String {


I see, then maybe we could reuse

foundry/crates/evm/core/src/decode.rs

Line 227 in e6098ac

fn trimmed_hex(s: &[u8]) -> String {

@DaniPopes @zerosnacks wdyt?

Schema for 7201 buckets

d725fe4

tom2o17 requested review from DaniPopes, klkvr, mattsse, grandizzy, yash-atreya and zerosnacks as code owners August 26, 2025 16:19

github-project-automation bot added this to Foundry Aug 26, 2025

tom2o17 requested review from onbjerg and 0xrusowsky as code owners August 26, 2025 16:19

Clippy ++ fmt

ba0031a

grandizzy requested changes Aug 28, 2025

View reviewed changes

Edits @grandizzy

586b827

tom2o17 commented Aug 28, 2025

View reviewed changes

Merge branch 'master' into eip-7201-support

673d958

tom2o17 requested a review from grandizzy August 28, 2025 17:03

Fix: cargo fmt --all --check

0eb1f43

grandizzy reviewed Aug 29, 2025

View reviewed changes

tom2o17 and others added 2 commits August 29, 2025 08:08

Merge branch 'master' into eip-7201-support

1d8cd02

Edits less short_hex -> trimmed_hex

c761f2e

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[WIP-RFC] Inspect EIP-7201 bucket Schema #11429

[WIP-RFC] Inspect EIP-7201 bucket Schema #11429

Uh oh!

tom2o17 commented Aug 26, 2025 •

edited

Loading

Uh oh!

grandizzy left a comment

Uh oh!

grandizzy Aug 28, 2025

Uh oh!

tom2o17 Aug 28, 2025

Uh oh!

grandizzy Aug 29, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tom2o17 left a comment

Uh oh!

tom2o17 Aug 28, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

grandizzy Aug 29, 2025

Uh oh!

Uh oh!

[WIP-RFC] Inspect EIP-7201 bucket Schema #11429

Are you sure you want to change the base?

[WIP-RFC] Inspect EIP-7201 bucket Schema #11429

Uh oh!

Conversation

tom2o17 commented Aug 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Motivation

Solution

PR Checklist

Disclaimers

Uh oh!

grandizzy left a comment

Choose a reason for hiding this comment

Uh oh!

grandizzy Aug 28, 2025

Choose a reason for hiding this comment

Uh oh!

tom2o17 Aug 28, 2025

Choose a reason for hiding this comment

Uh oh!

grandizzy Aug 29, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tom2o17 left a comment

Choose a reason for hiding this comment

Uh oh!

tom2o17 Aug 28, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

grandizzy Aug 29, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

tom2o17 commented Aug 26, 2025 •

edited

Loading